[ty] Add some missing calls to normalized_impl (#19074)
Some checks are pending
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / Fuzz for new ty panics (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / check playground (push) Blocked by required conditions
CI / benchmarks-instrumented (push) Blocked by required conditions
CI / benchmarks-walltime (push) Blocked by required conditions
[ty Playground] Release / publish (push) Waiting to run

## Summary

I hoped this might fix the latest stack overflows on
https://github.com/astral-sh/ruff/pull/18659... it doesn't look like it
does, but these changes seem like they're probably correct anyway...?

## Test Plan

<!-- How was it tested? -->
This commit is contained in:
Alex Waygood 2025-07-01 17:57:52 +01:00 committed by GitHub
parent 47733c0647
commit 316c1b21e2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions

View file

@ -385,7 +385,8 @@ impl<'db> Specialization<'db> {
let tuple_inner = self let tuple_inner = self
.tuple_inner(db) .tuple_inner(db)
.and_then(|tuple| tuple.normalized_impl(db, visitor)); .and_then(|tuple| tuple.normalized_impl(db, visitor));
Self::new(db, self.generic_context(db), types, tuple_inner) let context = self.generic_context(db).normalized_impl(db, visitor);
Self::new(db, context, types, tuple_inner)
} }
pub(super) fn materialize(self, db: &'db dyn Db, variance: TypeVarVariance) -> Self { pub(super) fn materialize(self, db: &'db dyn Db, variance: TypeVarVariance) -> Self {

View file

@ -654,7 +654,8 @@ impl<'db> VariableLengthTuple<Type<'db>> {
.prenormalized_suffix_elements(db, None) .prenormalized_suffix_elements(db, None)
.map(|ty| ty.normalized_impl(db, visitor)) .map(|ty| ty.normalized_impl(db, visitor))
.collect::<Vec<_>>(); .collect::<Vec<_>>();
Self::mixed(prefix, self.variable.normalized(db), suffix) let variable = self.variable.normalized_impl(db, visitor);
Self::mixed(prefix, variable, suffix)
} }
fn materialize(&self, db: &'db dyn Db, variance: TypeVarVariance) -> TupleSpec<'db> { fn materialize(&self, db: &'db dyn Db, variance: TypeVarVariance) -> TupleSpec<'db> {