mirror of
https://github.com/astral-sh/ruff.git
synced 2025-10-25 17:38:15 +00:00
SIM110: any() is ~3x slower than the code it replaces (#12746)
> ~Builtins are also more efficient than `for` loops.~
Let's not promise performance because this code transformation does not
deliver.
Benchmark written by @dcbaker
> `any()` seems to be about 1/3 as fast (Python 3.11.9, NixOS):
```python
loop = 'abcdef'.split()
found = 'f'
nfound = 'g'
def test1():
for x in loop:
if x == found:
return True
return False
def test2():
return any(x == found for x in loop)
def test3():
for x in loop:
if x == nfound:
return True
return False
def test4():
return any(x == nfound for x in loop)
if __name__ == "__main__":
import timeit
print('for loop (found) :', timeit.timeit(test1))
print('for loop (not found):', timeit.timeit(test3))
print('any() (found) :', timeit.timeit(test2))
print('any() (not found) :', timeit.timeit(test4))
```
```
for loop (found) : 0.051076093994197436
for loop (not found): 0.04388196699437685
any() (found) : 0.15422860698890872
any() (not found) : 0.15568504799739458
```
I have retested with longer lists and on multiple Python versions with
similar results.
This commit is contained in:
parent
f577e03021
commit
33e9a6a54e
1 changed files with 1 additions and 2 deletions
|
|
@ -18,8 +18,7 @@ use crate::line_width::LineWidthBuilder;
|
|||
/// `any` or `all`.
|
||||
///
|
||||
/// ## Why is this bad?
|
||||
/// Using a builtin function is more concise and readable. Builtins are also
|
||||
/// more efficient than `for` loops.
|
||||
/// Using a builtin function is more concise and readable.
|
||||
///
|
||||
/// ## Example
|
||||
/// ```python
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue