mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-31 15:47:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

[syntax-errors] Fix star annotation before Python 3.11 (#16878)

Browse source 
Summary
--

Fixes #16874. I previously emitted a syntax error when starred
annotations were _allowed_ rather than when they were actually used.
This caused false positives for any starred parameter name because these
are allowed to have starred annotations but not required to. The fix is
to check if the annotation is actually starred after parsing it.

Test Plan
--

New inline parser tests derived from the initial report and more
examples from the comments, although I think the first case should cover
them all.
This commit is contained in:
Brent Westbrook 2025-03-20 17:44:52 -04:00 • committed by GitHub
parent 67602512b6
commit 42cbce538b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 415 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

389
crates/ruff_python_parser/tests/snapshots/valid_syntax@param_with_star_annotation_py310.py.snap Normal file
View file

@ -0,0 +1,389 @@
---
source: crates/ruff_python_parser/tests/fixtures.rs
input_file: crates/ruff_python_parser/resources/inline/ok/param_with_star_annotation_py310.py
---
## AST
```
Module(
ModModule {
range: 0..432,
body: [
ImportFrom(
StmtImportFrom {
range: 169..206,
module: Some(
Identifier {
id: Name("typing"),
range: 174..180,
},
),
names: [
Alias {
range: 188..197,
name: Identifier {
id: Name("Annotated"),
range: 188..197,
},
asname: None,
},
Alias {
range: 199..206,
name: Identifier {
id: Name("Literal"),
range: 199..206,
},
asname: None,
},
],
level: 0,
},
),
FunctionDef(
StmtFunctionDef {
range: 207..230,
is_async: false,
decorator_list: [],
name: Identifier {
id: Name("foo"),
range: 211..214,
},
type_params: None,
parameters: Parameters {
range: 214..225,
posonlyargs: [],
args: [],
vararg: Some(
Parameter {
range: 215..224,
name: Identifier {
id: Name("args"),
range: 216..220,
},
annotation: Some(
Name(
ExprName {
range: 222..224,
id: Name("Ts"),
ctx: Load,
},
),
),
},
),
kwonlyargs: [],
kwarg: None,
},
returns: None,
body: [
Expr(
StmtExpr {
range: 227..230,
value: EllipsisLiteral(
ExprEllipsisLiteral {
range: 227..230,
},
),
},
),
],
},
),
FunctionDef(
StmtFunctionDef {
range: 231..295,
is_async: false,
decorator_list: [],
name: Identifier {
id: Name("foo"),
range: 235..238,
},
type_params: None,
parameters: Parameters {
range: 238..290,
posonlyargs: [],
args: [],
vararg: Some(
Parameter {
range: 239..289,
name: Identifier {
id: Name("x"),
range: 240..241,
},
annotation: Some(
Subscript(
ExprSubscript {
range: 243..289,
value: Name(
ExprName {
range: 243..250,
id: Name("Literal"),
ctx: Load,
},
),
slice: StringLiteral(
ExprStringLiteral {
range: 251..288,
value: StringLiteralValue {
inner: Single(
StringLiteral {
range: 251..288,
value: "this should allow arbitrary strings",
flags: StringLiteralFlags {
quote_style: Double,
prefix: Empty,
triple_quoted: false,
},
},
),
},
},
),
ctx: Load,
},
),
),
},
),
kwonlyargs: [],
kwarg: None,
},
returns: None,
body: [
Expr(
StmtExpr {
range: 292..295,
value: EllipsisLiteral(
ExprEllipsisLiteral {
range: 292..295,
},
),
},
),
],
},
),
FunctionDef(
StmtFunctionDef {
range: 296..367,
is_async: false,
decorator_list: [],
name: Identifier {
id: Name("foo"),
range: 300..303,
},
type_params: None,
parameters: Parameters {
range: 303..362,
posonlyargs: [],
args: [],
vararg: Some(
Parameter {
range: 304..361,
name: Identifier {
id: Name("x"),
range: 305..306,
},
annotation: Some(
Subscript(
ExprSubscript {
range: 308..361,
value: Name(
ExprName {
range: 308..317,
id: Name("Annotated"),
ctx: Load,
},
),
slice: Tuple(
ExprTuple {
range: 318..360,
elts: [
Name(
ExprName {
range: 318..321,
id: Name("str"),
ctx: Load,
},
),
StringLiteral(
ExprStringLiteral {
range: 323..360,
value: StringLiteralValue {
inner: Single(
StringLiteral {
range: 323..360,
value: "this should allow arbitrary strings",
flags: StringLiteralFlags {
quote_style: Double,
prefix: Empty,
triple_quoted: false,
},
},
),
},
},
),
],
ctx: Load,
parenthesized: false,
},
),
ctx: Load,
},
),
),
},
),
kwonlyargs: [],
kwarg: None,
},
returns: None,
body: [
Expr(
StmtExpr {
range: 364..367,
value: EllipsisLiteral(
ExprEllipsisLiteral {
range: 364..367,
},
),
},
),
],
},
),
FunctionDef(
StmtFunctionDef {
range: 368..405,
is_async: false,
decorator_list: [],
name: Identifier {
id: Name("foo"),
range: 372..375,
},
type_params: None,
parameters: Parameters {
range: 375..400,
posonlyargs: [],
args: [],
vararg: Some(
Parameter {
range: 376..386,
name: Identifier {
id: Name("args"),
range: 377..381,
},
annotation: Some(
Name(
ExprName {
range: 383..386,
id: Name("str"),
ctx: Load,
},
),
),
},
),
kwonlyargs: [],
kwarg: Some(
Parameter {
range: 388..399,
name: Identifier {
id: Name("kwds"),
range: 390..394,
},
annotation: Some(
Name(
ExprName {
range: 396..399,
id: Name("int"),
ctx: Load,
},
),
),
},
),
},
returns: None,
body: [
Expr(
StmtExpr {
range: 402..405,
value: EllipsisLiteral(
ExprEllipsisLiteral {
range: 402..405,
},
),
},
),
],
},
),
FunctionDef(
StmtFunctionDef {
range: 406..431,
is_async: false,
decorator_list: [],
name: Identifier {
id: Name("union"),
range: 410..415,
},
type_params: None,
parameters: Parameters {
range: 415..426,
posonlyargs: [],
args: [],
vararg: Some(
Parameter {
range: 416..425,
name: Identifier {
id: Name("x"),
range: 417..418,
},
annotation: Some(
BinOp(
ExprBinOp {
range: 420..425,
left: Name(
ExprName {
range: 420..421,
id: Name("A"),
ctx: Load,
},
),
op: BitOr,
right: Name(
ExprName {
range: 424..425,
id: Name("B"),
ctx: Load,
},
),
},
),
),
},
),
kwonlyargs: [],
kwarg: None,
},
returns: None,
body: [
Expr(
StmtExpr {
range: 428..431,
value: EllipsisLiteral(
ExprEllipsisLiteral {
range: 428..431,
},
),
},
),
],
},
),
],
},
)
```