mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-12-23 09:19:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor(blind_except.rs) inline `Truthiness` expression

Browse source
This commit is contained in:
lubaskin 2025-12-18 21:50:36 +03:00
parent b87814973f
commit 47bbc481b8
1 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

20
crates/ruff_linter/src/rules/flake8_blind_except/rules/blind_except.rs
View file

@ -232,11 +232,11 @@ impl<'a> StatementVisitor<'a> for LogExceptionVisitor<'a> {
"exception" => true,
attr if is_exc_info_compatible_log_method(attr) => {
arguments.find_keyword("exc_info").is_some_and(|keyword| {
let truthiness =
Truthiness::from_expr(&keyword.value, |id| {
self.semantic.has_builtin_binding(id)
});
truthiness.into_bool().unwrap_or(true) // into_bool() can only return None if contained value is Truthiness::Unknown which can be exception object
Truthiness::from_expr(&keyword.value, |id| {
self.semantic.has_builtin_binding(id)
})
.into_bool()
.unwrap_or(true) // into_bool() can only return None if contained value is Truthiness::Unknown which can be exception object
})
}
_ => false,
@ -253,11 +253,11 @@ impl<'a> StatementVisitor<'a> for LogExceptionVisitor<'a> {
if is_exc_info_compatible_log_method(method) =>
{
arguments.find_keyword("exc_info").is_some_and(|keyword| {
let truthiness =
Truthiness::from_expr(&keyword.value, |id| {
self.semantic.has_builtin_binding(id)
});
truthiness.into_bool().unwrap_or(true) // into_bool() can only return None if contained value is Truthiness::Unknown which can be exception object
Truthiness::from_expr(&keyword.value, |id| {
self.semantic.has_builtin_binding(id)
})
.into_bool()
.unwrap_or(true) // into_bool() can only return None if contained value is Truthiness::Unknown which can be exception object
})
}
_ => false,