mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-01 22:31:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Ambiguous unicode, only test unicode characters (#3814)

Browse source
This commit is contained in:
Micha Reiser 2023-03-31 19:03:00 +02:00 • committed by GitHub
parent 82584ad101
commit 48d8680e71
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 39 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

76
crates/ruff/src/rules/ruff/rules/ambiguous_unicode_character.rs
View file

@ -1698,45 +1698,47 @@ pub fn ambiguous_unicode_character(
let mut col_offset = 0;
let mut row_offset = 0;
for current_char in text.chars() {
// Search for confusing characters.
if let Some(representant) = CONFUSABLES.get(&(current_char as u32)) {
if !settings.allowed_confusables.contains(&current_char) {
let col = if row_offset == 0 {
start.column() + col_offset
} else {
col_offset
};
let location = Location::new(start.row() + row_offset, col);
let end_location = Location::new(location.row(), location.column() + 1);
let mut diagnostic = Diagnostic::new::<DiagnosticKind>(
match context {
Context::String => AmbiguousUnicodeCharacterString {
confusable: current_char,
representant: *representant as char,
if !current_char.is_ascii() {
// Search for confusing characters.
if let Some(representant) = CONFUSABLES.get(&(current_char as u32)).copied() {
if !settings.allowed_confusables.contains(&current_char) {
let col = if row_offset == 0 {
start.column() + col_offset
} else {
col_offset
};
let location = Location::new(start.row() + row_offset, col);
let end_location = Location::new(location.row(), location.column() + 1);
let mut diagnostic = Diagnostic::new::<DiagnosticKind>(
match context {
Context::String => AmbiguousUnicodeCharacterString {
confusable: current_char,
representant: representant as char,
}
.into(),
Context::Docstring => AmbiguousUnicodeCharacterDocstring {
confusable: current_char,
representant: representant as char,
}
.into(),
Context::Comment => AmbiguousUnicodeCharacterComment {
confusable: current_char,
representant: representant as char,
}
.into(),
},
Range::new(location, end_location),
);
if settings.rules.enabled(diagnostic.kind.rule()) {
if autofix.into() && settings.rules.should_fix(diagnostic.kind.rule()) {
diagnostic.set_fix(Edit::replacement(
(representant as char).to_string(),
location,
end_location,
));
}
.into(),
Context::Docstring => AmbiguousUnicodeCharacterDocstring {
confusable: current_char,
representant: *representant as char,
}
.into(),
Context::Comment => AmbiguousUnicodeCharacterComment {
confusable: current_char,
representant: *representant as char,
}
.into(),
},
Range::new(location, end_location),
);
if settings.rules.enabled(diagnostic.kind.rule()) {
if autofix.into() && settings.rules.should_fix(diagnostic.kind.rule()) {
diagnostic.set_fix(Edit::replacement(
(*representant as char).to_string(),
location,
end_location,
));
diagnostics.push(diagnostic);
}
diagnostics.push(diagnostic);
}
}
}