mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-07-07 21:25:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[ty] Re-enable multithreaded pydantic benchmark (#19176)

Browse source 
## Summary

I played with those numbers a bit locally and `sample_size=3,
sample_count=8` seemed like a rather stable setup. This means a single
sample consistents of 3 iterations of checking pydantic multithreaded.
And this is repeated 8 times for statistics. A single check took ~300 ms
previously on the runners, so this should only take 7 s.
This commit is contained in:
David Peter 2025-07-07 14:28:15 +02:00 • committed by GitHub
parent a6637964d2
commit 4aaf32476a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

25
crates/ruff_benchmark/benches/ty_walltime.rs
View file

@ -242,20 +242,19 @@ fn large(bencher: Bencher, benchmark: &Benchmark) {
run_single_threaded(bencher, benchmark); run_single_threaded(bencher, benchmark);
} }
// Currently disabled because the benchmark is too noisy (± 10%) to give useful feedback. #[bench(args=[&*PYDANTIC], sample_size=3, sample_count=8)]
// #[bench(args=[&*PYDANTIC], sample_size=3, sample_count=3)] fn multithreaded(bencher: Bencher, benchmark: &Benchmark) {
// fn multithreaded(bencher: Bencher, benchmark: &Benchmark) { let thread_pool = ThreadPoolBuilder::new().build().unwrap();
// let thread_pool = ThreadPoolBuilder::new().build().unwrap();
// bencher bencher
// .with_inputs(|| benchmark.setup_iteration()) .with_inputs(|| benchmark.setup_iteration())
// .bench_local_values(|db| { .bench_local_values(|db| {
// thread_pool.install(|| { thread_pool.install(|| {
// check_project(&db, benchmark.max_diagnostics); check_project(&db, benchmark.max_diagnostics);
// db db
// }) })
// }); });
// } }
fn main() { fn main() {
ThreadPoolBuilder::new() ThreadPoolBuilder::new()