mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-02 14:51:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Avoid useless-else-on-loop for break within match (#3136)

Browse source
This commit is contained in:
Charlie Marsh 2023-02-22 14:12:44 -05:00 • committed by GitHub
parent 6ced5122e4
commit 4ad4e3e091
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/ruff/resources/test/fixtures/pylint/useless_else_on_loop.py vendored
View file

@ -124,3 +124,14 @@ def test_break_in_with():
else:
return True
return False
def test_break_in_match():
"""no false positive for break in match"""
for name in ["demo"]:
match name:
case "demo":
break
else:
return True
return False

5
crates/ruff/src/rules/pylint/rules/useless_else_on_loop.rs
View file

@ -1,5 +1,5 @@
use ruff_macros::{define_violation, derive_message_formats};
use rustpython_parser::ast::{ExcepthandlerKind, Stmt, StmtKind};
use rustpython_parser::ast::{ExcepthandlerKind, MatchCase, Stmt, StmtKind};
use crate::ast::helpers;
use crate::checkers::ast::Checker;
@ -23,6 +23,9 @@ fn loop_exits_early(body: &[Stmt]) -> bool {
body.iter().any(|stmt| match &stmt.node {
StmtKind::If { body, orelse, .. } => loop_exits_early(body) || loop_exits_early(orelse),
StmtKind::With { body, .. } | StmtKind::AsyncWith { body, .. } => loop_exits_early(body),
StmtKind::Match { cases, .. } => cases
.iter()
.any(|MatchCase { body, .. }| loop_exits_early(body)),
StmtKind::Try {
body,
handlers,