mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-02 14:51:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[flake8-bandit] Fix truthiness: dict-only ** displays not truthy for shell (S602, S604, S609) (#20177)

Browse source 
## Summary
Fixes #19927
This commit is contained in:
Dan Parizher 2025-09-10 17:06:33 -04:00 • committed by GitHub
parent cde5e4e343
commit 4c64ba4ee1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 42 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

17
crates/ruff_python_ast/src/helpers.rs
View file

@ -1294,15 +1294,14 @@ impl Truthiness {
return Self::Falsey;
}
if dict.items.iter().all(|item| {
matches!(
item,
DictItem {
key: None,
value: Expr::Name(..)
}
)
}) {
// If the dict consists only of double-starred items (e.g., {**x, **y}),
// consider its truthiness unknown. This matches lists/sets/tuples containing
// only starred elements, which are also Unknown.
if dict
.items
.iter()
.all(|item| matches!(item, DictItem { key: None, .. }))
{
// {**foo} / {**foo, **bar}
Self::Unknown
} else {