mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-01 14:21:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

[red-knot] Fix loading color in dark mode (#17237)
Some checks are pending
CI / cargo clippy (push) Blocked by required conditions
Details
CI / cargo build (msrv) (push) Blocked by required conditions
Details
CI / cargo fuzz build (push) Blocked by required conditions
Details
CI / Determine changes (push) Waiting to run
Details
CI / cargo fmt (push) Waiting to run
Details
CI / cargo test (linux) (push) Blocked by required conditions
Details
CI / cargo test (linux, release) (push) Blocked by required conditions
Details
CI / cargo test (windows) (push) Blocked by required conditions
Details
CI / cargo test (wasm) (push) Blocked by required conditions
Details
CI / cargo build (release) (push) Waiting to run
Details
CI / fuzz parser (push) Blocked by required conditions
Details
CI / test scripts (push) Blocked by required conditions
Details
CI / ecosystem (push) Blocked by required conditions
Details
CI / cargo shear (push) Blocked by required conditions
Details
CI / python package (push) Waiting to run
Details
CI / pre-commit (push) Waiting to run
Details
CI / mkdocs (push) Waiting to run
Details
CI / formatter instabilities and black similarity (push) Blocked by required conditions
Details
CI / test ruff-lsp (push) Blocked by required conditions
Details
CI / check playground (push) Blocked by required conditions
Details
CI / benchmarks (push) Blocked by required conditions
Details
[Knot Playground] Release / publish (push) Waiting to run
Details

Browse source 
## Summary

The loading indicator on dark mode isn't "visible" because it's black on
black. Use white as text color instead.
This commit is contained in:
Micha Reiser 2025-04-06 19:30:21 +02:00 • committed by GitHub
parent ac5d220d75
commit 51bdb87fd8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
playground/knot/src/Editor/SecondaryPanel.tsx
View file

@ -109,7 +109,9 @@ function Run({ files, theme }: { files: ReadonlyFiles; theme: Theme }) {
}
return (
<Suspense fallback={<div className="text-center">Loading</div>}>
<Suspense
fallback={<div className="text-center dark:text-white">Loading</div>}
>
<RunWithPyiodide
theme={theme}
files={files}

6
playground/knot/src/Playground.tsx
View file

@ -480,7 +480,11 @@ function updateFile(
}
function Loading() {
return <div className="align-middle text-center my-2">Loading...</div>;
return (
<div className="align-middle text-current text-center my-2 dark:text-white">
Loading...
</div>
);
}
function restoreWorkspace(