mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-07-25 14:03:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix StmtAnnAssign formatting by mirroring StmtAssign (#5732)

Browse source 
## Summary

`StmtAnnAssign` would not insert parentheses when breaking the same way
`StmtAssign` does, causing unstable formatting and likely some syntax
errors.

## Test Plan

I added a regression test.
This commit is contained in:
konsti 2023-07-13 12:51:25 +02:00 • committed by GitHub
parent b1781abffb
commit 549173b395
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 69 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

19
crates/ruff_python_formatter/src/statement/stmt_ann_assign.rs
View file

@ -1,3 +1,5 @@
use crate::expression::maybe_parenthesize_expression;
use crate::expression::parentheses::Parenthesize;
use crate::prelude::*;
use crate::FormatNodeRule;
use ruff_formatter::write;
@ -18,11 +20,24 @@ impl FormatNodeRule<StmtAnnAssign> for FormatStmtAnnAssign {
write!(
f,
[target.format(), text(":"), space(), annotation.format()]
[
target.format(),
text(":"),
space(),
maybe_parenthesize_expression(annotation, item, Parenthesize::IfBreaks)
]
)?;
if let Some(value) = value {
write!(f, [space(), text("="), space(), value.format()])?;
write!(
f,
[
space(),
text("="),
space(),
maybe_parenthesize_expression(value, item, Parenthesize::IfBreaks)
]
)?;
}
Ok(())