mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-14 20:40:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fix StmtAnnAssign formatting by mirroring StmtAssign (#5732)

Browse source 
## Summary

`StmtAnnAssign` would not insert parentheses when breaking the same way
`StmtAssign` does, causing unstable formatting and likely some syntax
errors.

## Test Plan

I added a regression test.
This commit is contained in:
konsti 2023-07-13 12:51:25 +02:00 • committed by GitHub
parent b1781abffb
commit 549173b395
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 69 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

25
crates/ruff_python_formatter/tests/snapshots/format@statement__ann_assign.py.snap
View file

@ -4,21 +4,28 @@ input_file: crates/ruff_python_formatter/resources/test/fixtures/ruff/statement/
---
## Input
```py
tree_depth += 1
# Regression test: Don't forget the parentheses in the value when breaking
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa: int = a + 1 * a
greeting += "This is very long, formal greeting for whomever is name here. Dear %s, it will break the line" % len(
name
)
# Regression test: Don't forget the parentheses in the annotation when breaking
class DefaultRunner:
task_runner_cls: TaskRunnerProtocol | typing.Callable[[], typing.Any] = DefaultTaskRunner
```
## Output
```py
tree_depth += 1
greeting += (
"This is very long, formal greeting for whomever is name here. Dear %s, it will break the line"
% len(name)
# Regression test: Don't forget the parentheses in the value when breaking
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa: int = (
a + 1 * a
)
# Regression test: Don't forget the parentheses in the annotation when breaking
class DefaultRunner:
task_runner_cls: (
TaskRunnerProtocol | typing.Callable[[], typing.Any]
) = DefaultTaskRunner
```

25
crates/ruff_python_formatter/tests/snapshots/format@statement__aug_assign.py.snap Normal file
View file

@ -0,0 +1,25 @@
---
source: crates/ruff_python_formatter/tests/fixtures.rs
input_file: crates/ruff_python_formatter/resources/test/fixtures/ruff/statement/aug_assign.py
---
## Input
```py
tree_depth += 1
greeting += "This is very long, formal greeting for whomever is name here. Dear %s, it will break the line" % len(
name
)
```
## Output
```py
tree_depth += 1
greeting += (
"This is very long, formal greeting for whomever is name here. Dear %s, it will break the line"
% len(name)
)
```