mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-03 02:12:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Avoid PTH206 with maxsplit (#6283)

Browse source 
## Summary

Avoid suggesting `Path.parts` when a `maxsplit` is specified, since
these behavior differently.

## Test Plan

`cargo test`
This commit is contained in:
Charlie Marsh 2023-08-02 14:16:57 -04:00 • committed by GitHub
parent 23b8fc4366
commit 556abf4bd3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ruff/resources/test/fixtures/flake8_use_pathlib/PTH206.py vendored
View file

@ -18,3 +18,5 @@ file_name.split(os.sep)
# OK # OK
"foo/bar/".split("/") "foo/bar/".split("/")
"foo/bar/".split(os.sep, 1)
"foo/bar/".split(1, sep=os.sep)

7
crates/ruff/src/rules/flake8_use_pathlib/rules/os_sep_split.rs
View file

@ -60,7 +60,12 @@ pub(crate) fn os_sep_split(checker: &mut Checker, call: &ast::ExprCall) {
return; return;
}; };
// Match `.split(os.sep)` or `.split(sep=os.sep)` // Match `.split(os.sep)` or `.split(sep=os.sep)`, but avoid cases in which a `maxsplit` is
// specified.
if call.arguments.len() != 1 {
return;
}
let Some(sep) = call.arguments.find_argument("sep", 0) else { let Some(sep) = call.arguments.find_argument("sep", 0) else {
return; return;
}; };