mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-01 06:11:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Avoid treating deferred string annotations as required-at-runtime (#2779)

Browse source
This commit is contained in:
Charlie Marsh 2023-02-11 15:00:08 -05:00 • committed by GitHub
parent 74731a3456
commit 5a70a573cd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 17 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ruff/resources/test/fixtures/flake8_type_checking/TCH002.py vendored
View file

@ -44,7 +44,7 @@ def f():
def f(): def f():
import pandas as pd import pandas as pd # TCH002
x = dict["pd.DataFrame", "pd.DataFrame"] x = dict["pd.DataFrame", "pd.DataFrame"]

5
crates/ruff/src/checkers/ast.rs
View file

@ -3900,7 +3900,10 @@ impl<'a> Checker<'a> {
} }
pub const fn execution_context(&self) -> ExecutionContext { pub const fn execution_context(&self) -> ExecutionContext {
if self.in_type_checking_block || self.in_annotation { if self.in_type_checking_block
|| self.in_annotation
|| self.in_deferred_string_type_definition
{
ExecutionContext::Typing ExecutionContext::Typing
} else { } else {
ExecutionContext::Runtime ExecutionContext::Runtime

12
crates/ruff/src/rules/flake8_type_checking/snapshots/ruff__rules__flake8_type_checking__tests__runtime-import-in-type-checking-block_TCH004_8.py.snap
View file

@ -2,15 +2,5 @@
source: crates/ruff/src/rules/flake8_type_checking/mod.rs source: crates/ruff/src/rules/flake8_type_checking/mod.rs
expression: diagnostics expression: diagnostics
--- ---
- kind: []
RuntimeImportInTypeCheckingBlock:
full_name: typing.Any
location:
row: 5
column: 23
end_location:
row: 5
column: 26
fix: ~
parent: ~

11
crates/ruff/src/rules/flake8_type_checking/snapshots/ruff__rules__flake8_type_checking__tests__typing-only-third-party-import_TCH002.py.snap
View file

@ -79,4 +79,15 @@ expression: diagnostics
column: 23 column: 23
fix: ~ fix: ~
parent: ~ parent: ~
- kind:
TypingOnlyThirdPartyImport:
full_name: pandas
location:
row: 47
column: 11
end_location:
row: 47
column: 23
fix: ~
parent: ~