mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-29 13:24:57 +00:00
[airflow
] Convert DatasetOrTimeSchedule(datasets=...)
to AssetOrTimeSchedule(assets=...)
(AIR311
) (#20202)
<!-- Thank you for contributing to Ruff/ty! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? (Please prefix with `[ty]` for ty pull requests.) - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> update the argument `datasets` as `assets` ## Test Plan <!-- How was it tested? --> update fixture accordingly
This commit is contained in:
parent
c402bf8ae2
commit
5d7c17c20a
3 changed files with 27 additions and 5 deletions
|
@ -70,7 +70,7 @@ from airflow.timetables.datasets import DatasetOrTimeSchedule
|
||||||
from airflow.utils.dag_parsing_context import get_parsing_context
|
from airflow.utils.dag_parsing_context import get_parsing_context
|
||||||
|
|
||||||
# airflow.timetables.datasets
|
# airflow.timetables.datasets
|
||||||
DatasetOrTimeSchedule()
|
DatasetOrTimeSchedule(datasets=[])
|
||||||
|
|
||||||
# airflow.utils.dag_parsing_context
|
# airflow.utils.dag_parsing_context
|
||||||
get_parsing_context()
|
get_parsing_context()
|
||||||
|
|
|
@ -157,6 +157,9 @@ fn check_call_arguments(checker: &Checker, qualified_name: &QualifiedName, argum
|
||||||
["airflow", .., "DAG" | "dag"] => {
|
["airflow", .., "DAG" | "dag"] => {
|
||||||
diagnostic_for_argument(checker, arguments, "sla_miss_callback", None);
|
diagnostic_for_argument(checker, arguments, "sla_miss_callback", None);
|
||||||
}
|
}
|
||||||
|
["airflow", "timetables", "datasets", "DatasetOrTimeSchedule"] => {
|
||||||
|
diagnostic_for_argument(checker, arguments, "datasets", Some("assets"));
|
||||||
|
}
|
||||||
segments => {
|
segments => {
|
||||||
if is_airflow_builtin_or_provider(segments, "operators", "Operator") {
|
if is_airflow_builtin_or_provider(segments, "operators", "Operator") {
|
||||||
diagnostic_for_argument(checker, arguments, "sla", None);
|
diagnostic_for_argument(checker, arguments, "sla", None);
|
||||||
|
|
|
@ -558,7 +558,7 @@ AIR311 [*] `airflow.timetables.datasets.DatasetOrTimeSchedule` is removed in Air
|
||||||
--> AIR311_names.py:73:1
|
--> AIR311_names.py:73:1
|
||||||
|
|
|
|
||||||
72 | # airflow.timetables.datasets
|
72 | # airflow.timetables.datasets
|
||||||
73 | DatasetOrTimeSchedule()
|
73 | DatasetOrTimeSchedule(datasets=[])
|
||||||
| ^^^^^^^^^^^^^^^^^^^^^
|
| ^^^^^^^^^^^^^^^^^^^^^
|
||||||
74 |
|
74 |
|
||||||
75 | # airflow.utils.dag_parsing_context
|
75 | # airflow.utils.dag_parsing_context
|
||||||
|
@ -570,12 +570,31 @@ help: Use `AssetOrTimeSchedule` from `airflow.timetables.assets` instead.
|
||||||
71 + from airflow.timetables.assets import AssetOrTimeSchedule
|
71 + from airflow.timetables.assets import AssetOrTimeSchedule
|
||||||
72 |
|
72 |
|
||||||
73 | # airflow.timetables.datasets
|
73 | # airflow.timetables.datasets
|
||||||
- DatasetOrTimeSchedule()
|
- DatasetOrTimeSchedule(datasets=[])
|
||||||
74 + AssetOrTimeSchedule()
|
74 + AssetOrTimeSchedule(datasets=[])
|
||||||
75 |
|
75 |
|
||||||
76 | # airflow.utils.dag_parsing_context
|
76 | # airflow.utils.dag_parsing_context
|
||||||
77 | get_parsing_context()
|
77 | get_parsing_context()
|
||||||
|
|
||||||
|
AIR311 [*] `datasets` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
||||||
|
--> AIR311_names.py:73:23
|
||||||
|
|
|
||||||
|
72 | # airflow.timetables.datasets
|
||||||
|
73 | DatasetOrTimeSchedule(datasets=[])
|
||||||
|
| ^^^^^^^^
|
||||||
|
74 |
|
||||||
|
75 | # airflow.utils.dag_parsing_context
|
||||||
|
|
|
||||||
|
help: Use `assets` instead
|
||||||
|
70 | from airflow.utils.dag_parsing_context import get_parsing_context
|
||||||
|
71 |
|
||||||
|
72 | # airflow.timetables.datasets
|
||||||
|
- DatasetOrTimeSchedule(datasets=[])
|
||||||
|
73 + DatasetOrTimeSchedule(assets=[])
|
||||||
|
74 |
|
||||||
|
75 | # airflow.utils.dag_parsing_context
|
||||||
|
76 | get_parsing_context()
|
||||||
|
|
||||||
AIR311 [*] `airflow.utils.dag_parsing_context.get_parsing_context` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
AIR311 [*] `airflow.utils.dag_parsing_context.get_parsing_context` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
||||||
--> AIR311_names.py:76:1
|
--> AIR311_names.py:76:1
|
||||||
|
|
|
|
||||||
|
@ -593,7 +612,7 @@ help: Use `get_parsing_context` from `airflow.sdk` instead.
|
||||||
70 + from airflow.sdk import get_parsing_context
|
70 + from airflow.sdk import get_parsing_context
|
||||||
71 |
|
71 |
|
||||||
72 | # airflow.timetables.datasets
|
72 | # airflow.timetables.datasets
|
||||||
73 | DatasetOrTimeSchedule()
|
73 | DatasetOrTimeSchedule(datasets=[])
|
||||||
note: This is an unsafe fix and may change runtime behavior
|
note: This is an unsafe fix and may change runtime behavior
|
||||||
|
|
||||||
AIR311 [*] `airflow.decorators.base.DecoratedMappedOperator` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
AIR311 [*] `airflow.decorators.base.DecoratedMappedOperator` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue