mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-01 17:32:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[flake8-bugbear] Tweak B905 message to not suggest setting parameter strict= to False (#13656)

Browse source 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This commit is contained in:
qdegraaf 2024-10-07 13:56:17 +02:00 • committed by GitHub
parent 58a11b33da
commit 646e4136d7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/ruff_linter/src/rules/flake8_bugbear/rules/zip_without_explicit_strict.rs
View file

@ -16,9 +16,9 @@ use crate::fix::edits::add_argument;
/// resulting iterator will be silently truncated to the length of the shortest
/// iterable. This can lead to subtle bugs.
///
/// Use the `strict` parameter to raise a `ValueError` if the iterables are of
/// non-uniform length. If the iterables are intentionally different lengths, the
/// parameter should be explicitly set to `False`.
/// Pass `strict=True` to raise a `ValueError` if the iterables are of
/// non-uniform length. Alternatively, if the iterables are deliberately
/// different lengths, pass `strict=False` to make the intention explicit.
///
/// ## Example
/// ```python
@ -47,7 +47,7 @@ impl AlwaysFixableViolation for ZipWithoutExplicitStrict {
}
fn fix_title(&self) -> String {
"Add explicit `strict=False`".to_string()
"Add explicit value for parameter `strict=`".to_string()
}
}

20
crates/ruff_linter/src/rules/flake8_bugbear/snapshots/ruff_linter__rules__flake8_bugbear__tests__B905.py.snap
View file

@ -9,7 +9,7 @@ B905.py:4:1: B905 [*] `zip()` without an explicit `strict=` parameter
5 | zip(range(3))
6 | zip("a", "b")
|
= help: Add explicit `strict=False`
= help: Add explicit value for parameter `strict=`
ℹ Safe fix
1 1 | from itertools import count, cycle, repeat
@ -30,7 +30,7 @@ B905.py:5:1: B905 [*] `zip()` without an explicit `strict=` parameter
6 | zip("a", "b")
7 | zip("a", "b", *zip("c"))
|
= help: Add explicit `strict=False`
= help: Add explicit value for parameter `strict=`
ℹ Safe fix
2 2 |
@ -51,7 +51,7 @@ B905.py:6:1: B905 [*] `zip()` without an explicit `strict=` parameter
7 | zip("a", "b", *zip("c"))
8 | zip(zip("a"), strict=False)
|
= help: Add explicit `strict=False`
= help: Add explicit value for parameter `strict=`
ℹ Safe fix
3 3 | # Errors
@ -72,7 +72,7 @@ B905.py:7:1: B905 [*] `zip()` without an explicit `strict=` parameter
8 | zip(zip("a"), strict=False)
9 | zip(zip("a", strict=True))
|
= help: Add explicit `strict=False`
= help: Add explicit value for parameter `strict=`
ℹ Safe fix
4 4 | zip()
@ -93,7 +93,7 @@ B905.py:7:16: B905 [*] `zip()` without an explicit `strict=` parameter
8 | zip(zip("a"), strict=False)
9 | zip(zip("a", strict=True))
|
= help: Add explicit `strict=False`
= help: Add explicit value for parameter `strict=`
ℹ Safe fix
4 4 | zip()
@ -113,7 +113,7 @@ B905.py:8:5: B905 [*] `zip()` without an explicit `strict=` parameter
| ^^^^^^^^ B905
9 | zip(zip("a", strict=True))
|
= help: Add explicit `strict=False`
= help: Add explicit value for parameter `strict=`
ℹ Safe fix
5 5 | zip(range(3))
@ -134,7 +134,7 @@ B905.py:9:1: B905 [*] `zip()` without an explicit `strict=` parameter
10 |
11 | # OK
|
= help: Add explicit `strict=False`
= help: Add explicit value for parameter `strict=`
ℹ Safe fix
6 6 | zip("a", "b")
@ -153,7 +153,7 @@ B905.py:24:1: B905 [*] `zip()` without an explicit `strict=` parameter
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ B905
25 | zip([1, 2, 3], repeat(1, times=4))
|
= help: Add explicit `strict=False`
= help: Add explicit value for parameter `strict=`
ℹ Safe fix
21 21 | zip([1, 2, 3], repeat(1, times=None))
@ -174,7 +174,7 @@ B905.py:25:1: B905 [*] `zip()` without an explicit `strict=` parameter
26 |
27 | import builtins
|
= help: Add explicit `strict=False`
= help: Add explicit value for parameter `strict=`
ℹ Safe fix
22 22 |
@ -193,7 +193,7 @@ B905.py:29:1: B905 [*] `zip()` without an explicit `strict=` parameter
29 | builtins.zip([1, 2, 3])
| ^^^^^^^^^^^^^^^^^^^^^^^ B905
|
= help: Add explicit `strict=False`
= help: Add explicit value for parameter `strict=`
ℹ Safe fix
26 26 |