mirror of
https://github.com/astral-sh/ruff.git
synced 2025-07-31 17:03:48 +00:00
[red-knot] Tests for 'while' loop boundness (#14944)
Some checks are pending
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo build (release) (push) Waiting to run
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / pre-commit (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / benchmarks (push) Blocked by required conditions
Some checks are pending
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo build (release) (push) Waiting to run
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / pre-commit (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / benchmarks (push) Blocked by required conditions
## Summary Regression test(s) for something that broken while implementing #14759. We have similar tests for other control flow elements, but feel free to let me know if this seems superfluous. ## Test Plan New mdtests
This commit is contained in:
parent
dbc191d2d6
commit
657d26ff20
1 changed files with 51 additions and 4 deletions
|
@ -1,6 +1,6 @@
|
||||||
# While loops
|
# While loops
|
||||||
|
|
||||||
## Basic While Loop
|
## Basic `while` loop
|
||||||
|
|
||||||
```py
|
```py
|
||||||
def _(flag: bool):
|
def _(flag: bool):
|
||||||
|
@ -11,7 +11,7 @@ def _(flag: bool):
|
||||||
reveal_type(x) # revealed: Literal[1, 2]
|
reveal_type(x) # revealed: Literal[1, 2]
|
||||||
```
|
```
|
||||||
|
|
||||||
## While with else (no break)
|
## `while` with `else` (no `break`)
|
||||||
|
|
||||||
```py
|
```py
|
||||||
def _(flag: bool):
|
def _(flag: bool):
|
||||||
|
@ -25,7 +25,7 @@ def _(flag: bool):
|
||||||
reveal_type(x) # revealed: Literal[3]
|
reveal_type(x) # revealed: Literal[3]
|
||||||
```
|
```
|
||||||
|
|
||||||
## While with Else (may break)
|
## `while` with `else` (may `break`)
|
||||||
|
|
||||||
```py
|
```py
|
||||||
def _(flag: bool, flag2: bool):
|
def _(flag: bool, flag2: bool):
|
||||||
|
@ -44,7 +44,7 @@ def _(flag: bool, flag2: bool):
|
||||||
reveal_type(y) # revealed: Literal[1, 2, 4]
|
reveal_type(y) # revealed: Literal[1, 2, 4]
|
||||||
```
|
```
|
||||||
|
|
||||||
## Nested while loops
|
## Nested `while` loops
|
||||||
|
|
||||||
```py
|
```py
|
||||||
def flag() -> bool:
|
def flag() -> bool:
|
||||||
|
@ -69,3 +69,50 @@ else:
|
||||||
|
|
||||||
reveal_type(x) # revealed: Literal[3, 4, 5]
|
reveal_type(x) # revealed: Literal[3, 4, 5]
|
||||||
```
|
```
|
||||||
|
|
||||||
|
## Boundness
|
||||||
|
|
||||||
|
Make sure that the boundness information is correctly tracked in `while` loop control flow.
|
||||||
|
|
||||||
|
### Basic `while` loop
|
||||||
|
|
||||||
|
```py
|
||||||
|
def _(flag: bool):
|
||||||
|
while flag:
|
||||||
|
x = 1
|
||||||
|
|
||||||
|
# error: [possibly-unresolved-reference]
|
||||||
|
x
|
||||||
|
```
|
||||||
|
|
||||||
|
### `while` with `else` (no `break`)
|
||||||
|
|
||||||
|
```py
|
||||||
|
def _(flag: bool):
|
||||||
|
while flag:
|
||||||
|
y = 1
|
||||||
|
else:
|
||||||
|
x = 1
|
||||||
|
|
||||||
|
# no error, `x` is always bound
|
||||||
|
x
|
||||||
|
# error: [possibly-unresolved-reference]
|
||||||
|
y
|
||||||
|
```
|
||||||
|
|
||||||
|
### `while` with `else` (may `break`)
|
||||||
|
|
||||||
|
```py
|
||||||
|
def _(flag: bool, flag2: bool):
|
||||||
|
while flag:
|
||||||
|
x = 1
|
||||||
|
if flag2:
|
||||||
|
break
|
||||||
|
else:
|
||||||
|
y = 1
|
||||||
|
|
||||||
|
# error: [possibly-unresolved-reference]
|
||||||
|
x
|
||||||
|
# error: [possibly-unresolved-reference]
|
||||||
|
y
|
||||||
|
```
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue