mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-04 10:48:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[red-knot] Infer value expr for empty list / tuple target (#15121)

Browse source 
## Summary

This PR resolves
https://github.com/astral-sh/ruff/pull/15058#discussion_r1893868406 by
inferring the value expression even if there are no targets in the list
/ tuple expression.

## Test Plan

Remove TODO from corpus tests, making sure it doesn't panic.
This commit is contained in:
Dhruv Manilawala 2024-12-23 16:00:35 +05:30 • committed by GitHub
parent 2a99c0be02
commit 68ada05b00
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/red_knot_python_semantic/src/types/infer.rs
View file

@ -1826,11 +1826,14 @@ impl<'db> TypeInferenceBuilder<'db> {
}
}
/// Infer the definition type involved in a `target` expression.
/// Infer the definition types involved in a `target` expression.
///
/// This is used for assignment statements, for statements, etc. with a single or multiple
/// targets (unpacking).
// TODO: Remove the `value` argument once we handle all possible assignment targets.
///
/// # Panics
///
/// If the `value` is not a standalone expression.
fn infer_target(&mut self, target: &ast::Expr, value: &ast::Expr) {
match target {
ast::Expr::Name(name) => self.infer_definition(name),
@ -1839,6 +1842,9 @@ impl<'db> TypeInferenceBuilder<'db> {
for element in elts {
self.infer_target(element, value);
}
if elts.is_empty() {
self.infer_standalone_expression(value);
}
}
_ => {
// TODO: Remove this once we handle all possible assignment targets.

6
crates/red_knot_workspace/tests/check.rs
View file

@ -207,14 +207,12 @@ impl SourceOrderVisitor<'_> for PullTypesVisitor<'_> {
for target in &assign.targets {
self.visit_target(target);
}
// TODO
//self.visit_expr(&assign.value);
self.visit_expr(&assign.value);
return;
}
Stmt::For(for_stmt) => {
self.visit_target(&for_stmt.target);
// TODO
//self.visit_expr(&for_stmt.iter);
self.visit_expr(&for_stmt.iter);
self.visit_body(&for_stmt.body);
self.visit_body(&for_stmt.orelse);
return;