[ty] Use Top materializations for TypeIs special form (#20591)
Some checks failed
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / Fuzz for new ty panics (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / check playground (push) Blocked by required conditions
CI / benchmarks instrumented (ruff) (push) Blocked by required conditions
CI / benchmarks instrumented (ty) (push) Blocked by required conditions
CI / benchmarks-walltime (push) Blocked by required conditions
[ty Playground] Release / publish (push) Has been cancelled

This commit is contained in:
Alex Waygood 2025-09-26 18:24:43 +01:00 committed by GitHub
parent e4de179cdd
commit 6b3c493cff
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 48 additions and 1 deletions

View file

@ -1286,7 +1286,17 @@ impl<'db> TypeInferenceBuilder<'db, '_> {
Type::unknown()
}
_ => TypeIsType::unbound(self.db(), self.infer_type_expression(arguments_slice)),
_ => TypeIsType::unbound(
self.db(),
// N.B. Using the top materialization here is a pragmatic decision
// that makes us produce more intuitive results given how
// `TypeIs` is used in the real world (in particular, in typeshed).
// However, there's some debate about whether this is really
// fully correct. See <https://github.com/astral-sh/ruff/pull/20591>
// for more discussion.
self.infer_type_expression(arguments_slice)
.top_materialization(self.db()),
),
},
SpecialFormType::TypeGuard => {
self.infer_type_expression(arguments_slice);