mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-04 18:58:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fixes minor bug in SemanticModel::lookup_symbol (#14643)

Browse source 
## Summary

This came up as part of #12927 when implementing
`SemanticModel::simulate_runtime_load`.

Should be fairly self-explanatory, if the scope returns a binding with
`BindingKind::Annotation` the bottom part of the loop gets skipped, so
there's no chance for `seen_function` to have been updated. So unless
there's something subtle going on here, like function scopes never
containing bindings with `BindingKind::Annotation`, this seems like a
bug.

## Test Plan

`cargo nextest run`
This commit is contained in:
David Salvisberg 2024-11-27 22:50:19 +01:00 • committed by GitHub
parent 8a7ba5d2df
commit 6d61c8aa16
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/ruff_python_semantic/src/model.rs
View file

@ -645,6 +645,7 @@ impl<'a> SemanticModel<'a> {
}
class_variables_visible = scope.kind.is_type() && index == 0;
seen_function |= scope.kind.is_function();
if let Some(binding_id) = scope.get(symbol) {
match self.bindings[binding_id].kind {
@ -661,9 +662,6 @@ impl<'a> SemanticModel<'a> {
return None;
}
}
// FIXME: Shouldn't this happen above where `class_variables_visible` is set?
seen_function |= scope.kind.is_function();
}
None