mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-18 09:30:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Simplify iteration idioms (#13834)

Browse source 
Remove unnecessary uses of `.as_ref()`, `.iter()`, `&**` and similar, mostly in situations when iterating over variables. Many of these changes are only possible following #13826, when we bumped our MSRV to 1.80: several useful implementations on `&Box<[T]>` were only stabilised in Rust 1.80. Some of these changes we could have done earlier, however.
This commit is contained in:
Alex Waygood 2024-10-20 22:25:27 +01:00 • committed by GitHub
parent 7fd8e30eed
commit 72adb09bf3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
36 changed files with 72 additions and 73 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/ruff_python_ast/src/nodes.rs
View file

@ -2048,7 +2048,7 @@ impl PartialEq for ConcatenatedStringLiteral {
// The `zip` here is safe because we have checked the length of both parts.
self.strings
.iter()
.zip(other.strings.iter())
.zip(&other.strings)
.all(|(s1, s2)| s1 == s2)
}
}
@ -3660,6 +3660,14 @@ impl<'a> IntoIterator for &'a Parameters {
}
}
impl<'a> IntoIterator for &'a Box<Parameters> {
type IntoIter = ParametersIterator<'a>;
type Item = AnyParameterRef<'a>;
fn into_iter(self) -> Self::IntoIter {
(&**self).into_iter()
}
}
/// An alternative type of AST `arg`. This is used for each function argument that might have a default value.
/// Used by `Arguments` original type.
///