mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-11-19 20:24:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Remove redundant dir_fd check from helper

Browse source
This commit is contained in:
Dan 2025-11-11 16:41:25 -05:00
parent e066e9ba24
commit 74266724b4
1 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crates/ruff_linter/src/rules/flake8_use_pathlib/helpers.rs
View file

@ -47,9 +47,9 @@ pub(crate) fn is_pure_path_subclass_with_preview(checker: &Checker, segments: &[
false false
} }
/// We check functions that take only 1 argument, this does not apply to functions /// We check functions that take only 1 argument.
/// with `dir_fd` argument, because `dir_fd` is not supported by pathlib, /// The caller is responsible for checking that `dir_fd` is not set to a non-default value
/// so check if it's set to non-default values /// (since `dir_fd` is not supported by pathlib), but this helper allows `dir_fd=None` to pass through.
pub(crate) fn check_os_pathlib_single_arg_calls( pub(crate) fn check_os_pathlib_single_arg_calls(
checker: &Checker, checker: &Checker,
call: &ExprCall, call: &ExprCall,
@ -73,13 +73,9 @@ pub(crate) fn check_os_pathlib_single_arg_calls(
return; return;
} }
// If `dir_fd` is set to a non-default value, skip (pathlib doesn't support it)
if is_keyword_only_argument_non_default(&call.arguments, "dir_fd") {
return;
}
// If there are keyword arguments other than `dir_fd` or the main argument, skip // If there are keyword arguments other than `dir_fd` or the main argument, skip
// We need to allow the main argument to be passed as a keyword, and `dir_fd=None` // We need to allow the main argument to be passed as a keyword, and `dir_fd=None`
// Note: `dir_fd` non-default value checking is done by the caller before invoking this helper
let allowed_keywords = if has_keyword_arg { let allowed_keywords = if has_keyword_arg {
&[fn_argument, "dir_fd"][..] &[fn_argument, "dir_fd"][..]
} else { } else {