mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-09 18:02:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[red-knot] Narrowing - Not operator (#13942)

Browse source 
## Summary

After #13918 has landed, narrowing constraint negation became easy, so
adding support for `not` operator.

## Test Plan

Added a new mdtest file for `not` expression.

---------

Co-authored-by: Carl Meyer <carl@astral.sh>
This commit is contained in:
TomerBin 2024-10-28 22:27:26 +02:00 • committed by GitHub
parent 1f19aca632
commit 74cf66e4c2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 51 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

19
crates/red_knot_python_semantic/src/types/narrow.rs
View file

@ -129,13 +129,30 @@ impl<'db> NarrowingConstraintsBuilder<'db> {
}
fn evaluate_expression_constraint(&mut self, expression: Expression<'db>, is_positive: bool) {
match expression.node_ref(self.db).node() {
let expression_node = expression.node_ref(self.db).node();
self.evaluate_expression_node_constraint(expression_node, expression, is_positive);
}
fn evaluate_expression_node_constraint(
&mut self,
expression_node: &ruff_python_ast::Expr,
expression: Expression<'db>,
is_positive: bool,
) {
match expression_node {
ast::Expr::Compare(expr_compare) => {
self.add_expr_compare(expr_compare, expression, is_positive);
}
ast::Expr::Call(expr_call) => {
self.add_expr_call(expr_call, expression, is_positive);
}
ast::Expr::UnaryOp(unary_op) if unary_op.op == ast::UnaryOp::Not => {
self.evaluate_expression_node_constraint(
&unary_op.operand,
expression,
!is_positive,
);
}
_ => {} // TODO other test expression kinds
}
}