mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 05:44:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[ty] Integer indexing into bytes returns int (#18218)

Browse source 
## Summary

Resolves [#461](https://github.com/astral-sh/ty/issues/461).

ty was hardcoded to infer `BytesLiteral` types for integer indexing into
`BytesLiteral`. It will now infer `IntLiteral` types instead.

## Test Plan

Markdown tests.
This commit is contained in:
InSync 2025-05-20 21:44:12 +07:00 • committed by GitHub
parent 90ca0a4c13
commit 76ab3425d3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

16
crates/ty_python_semantic/resources/mdtest/subscript/bytes.md
View file

@ -5,16 +5,16 @@
```py ```py
b = b"\x00abc\xff" b = b"\x00abc\xff"
reveal_type(b[0]) # revealed: Literal[b"\x00"] reveal_type(b[0]) # revealed: Literal[0]
reveal_type(b[1]) # revealed: Literal[b"a"] reveal_type(b[1]) # revealed: Literal[97]
reveal_type(b[4]) # revealed: Literal[b"\xff"] reveal_type(b[4]) # revealed: Literal[255]
reveal_type(b[-1]) # revealed: Literal[b"\xff"] reveal_type(b[-1]) # revealed: Literal[255]
reveal_type(b[-2]) # revealed: Literal[b"c"] reveal_type(b[-2]) # revealed: Literal[99]
reveal_type(b[-5]) # revealed: Literal[b"\x00"] reveal_type(b[-5]) # revealed: Literal[0]
reveal_type(b[False]) # revealed: Literal[b"\x00"] reveal_type(b[False]) # revealed: Literal[0]
reveal_type(b[True]) # revealed: Literal[b"a"] reveal_type(b[True]) # revealed: Literal[97]
x = b[5] # error: [index-out-of-bounds] "Index 5 is out of bounds for bytes literal `Literal[b"\x00abc\xff"]` with length 5" x = b[5] # error: [index-out-of-bounds] "Index 5 is out of bounds for bytes literal `Literal[b"\x00abc\xff"]` with length 5"
reveal_type(x) # revealed: Unknown reveal_type(x) # revealed: Unknown

4
crates/ty_python_semantic/src/types/infer.rs
View file

@ -7265,7 +7265,7 @@ impl<'db> TypeInferenceBuilder<'db> {
Type::unknown() Type::unknown()
} }
} }
// Ex) Given `b"value"[1]`, return `b"a"` // Ex) Given `b"value"[1]`, return `97` (i.e., `ord(b"a")`)
(Type::BytesLiteral(literal_ty), Type::IntLiteral(int), _) (Type::BytesLiteral(literal_ty), Type::IntLiteral(int), _)
if i32::try_from(int).is_ok() => if i32::try_from(int).is_ok() =>
{ {
@ -7273,7 +7273,7 @@ impl<'db> TypeInferenceBuilder<'db> {
literal_value literal_value
.iter() .iter()
.py_index(i32::try_from(int).expect("checked in branch arm")) .py_index(i32::try_from(int).expect("checked in branch arm"))
.map(|byte| Type::bytes_literal(self.db(), &[*byte])) .map(|byte| Type::IntLiteral((*byte).into()))
.unwrap_or_else(|_| { .unwrap_or_else(|_| {
report_index_out_of_bounds( report_index_out_of_bounds(
&self.context, &self.context,