mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-04 10:48:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

New Singleton enum for PatternMatchSingleton node (#8063)

Browse source 
## Summary

This PR adds a new `Singleton` enum for the `PatternMatchSingleton`
node.

Earlier the node was using the `Constant` enum but the value for this
pattern can only be either `None`, `True` or `False`. With the coming PR
to remove the `Constant`, this node required a new type to fill in.

This also has the benefit of narrowing the type down to only the
possible values for the node as evident by the removal of `unreachable`.

## Test Plan

Update the AST snapshots and run `cargo test`.
This commit is contained in:
Dhruv Manilawala 2023-10-30 11:18:53 +05:30 • committed by GitHub
parent ee7d445ef5
commit 78bbf6d403
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 70 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ruff_python_parser/src/python.lalrpop
View file

@ -655,7 +655,7 @@ AddOpExpr: ast::ParenthesizedExpr = {
LiteralPattern: ast::Pattern = {
<location:@L> "None" <end_location:@R> => ast::PatternMatchSingleton {
value: ast::Constant::None,
value: ast::Singleton::None,
range: (location..end_location).into()
}.into(),
<location:@L> "True" <end_location:@R> => ast::PatternMatchSingleton {

4
crates/ruff_python_parser/src/python.rs
View file

@ -1,5 +1,5 @@
// auto-generated: "lalrpop 0.20.0"
// sha3: 01c7c57ce067fcf07c9a5450511cc48a2dd08cf821a5ff3b0f649e87d3c67022
// sha3: 5c061590e81d6c0a6b543c9e8d8d30e7d7a44ed6b20f2ac72ca61a0e33d0e647
use ruff_text_size::{Ranged, TextLen, TextRange, TextSize};
use ruff_python_ast::{self as ast, Int, IpyEscapeKind};
use crate::{
@ -34346,7 +34346,7 @@ fn __action115<
) -> ast::Pattern
{
ast::PatternMatchSingleton {
value: ast::Constant::None,
value: ast::Singleton::None,
range: (location..end_location).into()
}.into()
}

12
crates/ruff_python_parser/src/snapshots/ruff_python_parser__parser__tests__patma.snap
View file

@ -719,9 +719,7 @@ expression: parse_ast
MatchSingleton(
PatternMatchSingleton {
range: 621..625,
value: Bool(
true,
),
value: True,
},
),
],
@ -2402,9 +2400,7 @@ expression: parse_ast
pattern: MatchSingleton(
PatternMatchSingleton {
range: 1947..1952,
value: Bool(
false,
),
value: False,
},
),
guard: None,
@ -3051,9 +3047,7 @@ expression: parse_ast
MatchSingleton(
PatternMatchSingleton {
range: 2405..2410,
value: Bool(
false,
),
value: False,
},
),
],