mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-11-03 05:03:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

ruff server: An empty code action filter no longer returns notebook source actions (#11526)

Browse source 
## Summary

Fixes #11516

`ruff server` was sending both regular source actions and notebook
source actions back when passed an empty action filter. This PR makes a
few small changes so that notebook source actions are not sent when
regular source actions are sent, which means that an empty filter will
only return regular source actions.

## Test Plan

I confirmed that duplicate code actions no longer appeared in Neovim,
using a configuration similar to the one from the original issue.

<img width="509" alt="Screenshot 2024-05-23 at 11 48 48 PM"
src="9a5d6907-dd41-48bd-b015-8a344c5e0b3f">
This commit is contained in:
Jane Lewis 2024-05-24 00:20:39 -07:00 • committed by GitHub
parent 52c946a4c5
commit 81275a6c3d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 19 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

33
crates/ruff_server/src/server/api/requests/code_action.rs
View file

@ -45,31 +45,28 @@ impl super::BackgroundDocumentRequestHandler for CodeActions {
response.extend(noqa_comments(&snapshot, &fixes)); response.extend(noqa_comments(&snapshot, &fixes));
} }
if snapshot.client_settings().fix_all() if snapshot.client_settings().fix_all() {
&& supported_code_actions.contains(&SupportedCodeAction::SourceFixAll) if supported_code_actions.contains(&SupportedCodeAction::SourceFixAll) {
{
response.push(fix_all(&snapshot).with_failure_code(ErrorCode::InternalError)?); response.push(fix_all(&snapshot).with_failure_code(ErrorCode::InternalError)?);
} else if supported_code_actions.contains(&SupportedCodeAction::NotebookSourceFixAll) {
response
.push(notebook_fix_all(&snapshot).with_failure_code(ErrorCode::InternalError)?);
}
} }
if snapshot.client_settings().organize_imports() if snapshot.client_settings().organize_imports() {
&& supported_code_actions.contains(&SupportedCodeAction::SourceOrganizeImports) if supported_code_actions.contains(&SupportedCodeAction::SourceOrganizeImports) {
{ response
response.push(organize_imports(&snapshot).with_failure_code(ErrorCode::InternalError)?); .push(organize_imports(&snapshot).with_failure_code(ErrorCode::InternalError)?);
} } else if supported_code_actions
.contains(&SupportedCodeAction::NotebookSourceOrganizeImports)
if snapshot.client_settings().fix_all()
&& supported_code_actions.contains(&SupportedCodeAction::NotebookSourceFixAll)
{
response.push(notebook_fix_all(&snapshot).with_failure_code(ErrorCode::InternalError)?);
}
if snapshot.client_settings().organize_imports()
&& supported_code_actions.contains(&SupportedCodeAction::NotebookSourceOrganizeImports)
{ {
response.push( response.push(
notebook_organize_imports(&snapshot).with_failure_code(ErrorCode::InternalError)?, notebook_organize_imports(&snapshot)
.with_failure_code(ErrorCode::InternalError)?,
); );
} }
}
Ok(Some(response)) Ok(Some(response))
} }