mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-04 10:48:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[red-knot] Add a couple more tests for * imports (#17270)

Browse source 
## Summary

Some more edge cases that I thought of while working on integrating
knowledge of statically known branches into the `*`-import machinery

## Test Plan

`cargo test -p red_knot_python_semantic`
This commit is contained in:
Alex Waygood 2025-04-07 12:12:28 +01:00 • committed by GitHub
parent 3150812ac4
commit 81cf860dc8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 123 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

125
crates/red_knot_python_semantic/resources/mdtest/import/star.md
View file

@ -158,8 +158,15 @@ def J(): ...
type K = int
with () as L: # error: [invalid-context-manager]
...
class ContextManagerThatMightNotRunToCompletion:
def __enter__(self) -> "ContextManagerThatMightNotRunToCompletion":
return self
def __exit__(self, *args) -> typing.Literal[True]:
return True
with ContextManagerThatMightNotRunToCompletion() as L:
U = ...
match 42:
case {"something": M}:
@ -176,6 +183,15 @@ match 42:
...
case T:
...
def boolean_condition() -> bool:
return True
if boolean_condition():
V = ...
while boolean_condition():
W = ...
```
`b.py`:
@ -206,12 +222,97 @@ print((
R, # TODO: could emit diagnostic about being possibly unbound
S, # TODO: could emit diagnostic about being possibly unbound
T, # TODO: could emit diagnostic about being possibly unbound
U, # TODO: could emit diagnostic about being possibly unbound
V, # TODO: could emit diagnostic about being possibly unbound
W, # TODO: could emit diagnostic about being possibly unbound
typing,
OrderedDict,
Foo,
))
```
### Esoteric possible redefinitions following definitely bound prior definitions
There should be no complaint about the symbols being possibly unbound in `b.py` here: although the
second definition might or might not take place, each symbol is definitely bound by a prior
definition.
`a.py`:
```py
from typing import Literal
A = 1
B = 2
C = 3
D = 4
E = 5
F = 6
G = 7
H = 8
I = 9
J = 10
K = 11
L = 12
for A in [1]:
...
match 42:
case {"something": B}:
...
case [*C]:
...
case [D]:
...
case E | F:
...
case object(foo=G):
...
case object(H):
...
case I:
...
def boolean_condition() -> bool:
return True
if boolean_condition():
J = ...
while boolean_condition():
K = ...
class ContextManagerThatMightNotRunToCompletion:
def __enter__(self) -> "ContextManagerThatMightNotRunToCompletion":
return self
def __exit__(self, *args) -> Literal[True]:
return True
with ContextManagerThatMightNotRunToCompletion():
L = ...
```
`b.py`:
```py
from a import *
print(A)
print(B)
print(C)
print(D)
print(E)
print(F)
print(G)
print(H)
print(I)
print(J)
print(K)
print(L)
```
### Definitions in function-like scopes are not global definitions
Except for some cases involving walrus expressions inside comprehension scopes.
@ -428,9 +529,20 @@ else:
Z: int = 42
```
`aa.py`:
```py
import sys
if sys.version_info >= (3, 12):
AA: bool = True
```
`b.py`:
```py
import sys
Z: bool = True
from a import *
@ -446,6 +558,15 @@ reveal_type(Y) # revealed: Unknown
# to be dead code given the `python-version` configuration.
# Thus this should reveal `Literal[True]`.
reveal_type(Z) # revealed: Unknown
if sys.version_info >= (3, 12):
from aa import *
# TODO: should reveal `Never`
reveal_type(AA) # revealed: Unknown
# error: [unresolved-reference]
reveal_type(AA) # revealed: Unknown
```
### Relative `*` imports