From 879512742f51a00d3a727e01115383c35cb17b4a Mon Sep 17 00:00:00 2001 From: Manuel Jacob Date: Thu, 16 Feb 2023 20:38:08 +0100 Subject: [PATCH] Skip .pytype directory by default. (#2966) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Pytype stores .pyi files in .pytype that ruff shouldn’t check or touch. --- README.md | 3 ++- crates/ruff/src/settings/defaults.rs | 1 + crates/ruff/src/settings/options.rs | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 17b77e70ff..ce278dc483 100644 --- a/README.md +++ b/README.md @@ -282,6 +282,7 @@ exclude = [ ".mypy_cache", ".nox", ".pants.d", + ".pytype", ".ruff_cache", ".svn", ".tox", @@ -2211,7 +2212,7 @@ For more information on the glob syntax, refer to the [`globset` documentation]( Note that you'll typically want to use [`extend-exclude`](#extend-exclude) to modify the excluded paths. -**Default value**: `[".bzr", ".direnv", ".eggs", ".git", ".hg", ".mypy_cache", ".nox", ".pants.d", ".ruff_cache", ".svn", ".tox", ".venv", "__pypackages__", "_build", "buck-out", "build", "dist", "node_modules", "venv"]` +**Default value**: `[".bzr", ".direnv", ".eggs", ".git", ".hg", ".mypy_cache", ".nox", ".pants.d", ".pytype", ".ruff_cache", ".svn", ".tox", ".venv", "__pypackages__", "_build", "buck-out", "build", "dist", "node_modules", "venv"]` **Type**: `list[str]` diff --git a/crates/ruff/src/settings/defaults.rs b/crates/ruff/src/settings/defaults.rs index ff5dc9b4a9..3ad76d61d8 100644 --- a/crates/ruff/src/settings/defaults.rs +++ b/crates/ruff/src/settings/defaults.rs @@ -40,6 +40,7 @@ pub static EXCLUDE: Lazy> = Lazy::new(|| { FilePattern::Builtin(".mypy_cache"), FilePattern::Builtin(".nox"), FilePattern::Builtin(".pants.d"), + FilePattern::Builtin(".pytype"), FilePattern::Builtin(".ruff_cache"), FilePattern::Builtin(".svn"), FilePattern::Builtin(".tox"), diff --git a/crates/ruff/src/settings/options.rs b/crates/ruff/src/settings/options.rs index 3b7ec34163..6a21b0b6b6 100644 --- a/crates/ruff/src/settings/options.rs +++ b/crates/ruff/src/settings/options.rs @@ -70,7 +70,7 @@ pub struct Options { /// default expression matches `_`, `__`, and `_var`, but not `_var_`. pub dummy_variable_rgx: Option, #[option( - default = r#"[".bzr", ".direnv", ".eggs", ".git", ".hg", ".mypy_cache", ".nox", ".pants.d", ".ruff_cache", ".svn", ".tox", ".venv", "__pypackages__", "_build", "buck-out", "build", "dist", "node_modules", "venv"]"#, + default = r#"[".bzr", ".direnv", ".eggs", ".git", ".hg", ".mypy_cache", ".nox", ".pants.d", ".pytype", ".ruff_cache", ".svn", ".tox", ".venv", "__pypackages__", "_build", "buck-out", "build", "dist", "node_modules", "venv"]"#, value_type = "list[str]", example = r#" exclude = [".venv"]