From 8cc14ad02d7a70d04ca1990d4be49f195977857d Mon Sep 17 00:00:00 2001 From: GiGaGon <107241144+MeGaGiGaGon@users.noreply.github.com> Date: Tue, 1 Jul 2025 06:57:34 -0700 Subject: [PATCH] [`flake8-datetimez`] Make `DTZ901` example error out-of-the-box (#19056) ## Summary Part of #18972 This PR makes [datetime-min-max (DTZ901)](https://docs.astral.sh/ruff/rules/datetime-min-max/#datetime-min-max-dtz901)'s example error out-of-the-box [Old example](https://play.ruff.rs/c1202727-1a18-4d3f-92a4-334ede07ed3e) ```py datetime.max ``` [New example](https://play.ruff.rs/af2c76aa-9beb-46bc-8e27-faf53ecdbe8c) ```py import datetime datetime.datetime.max ``` I also added imports to the problem demonstration and use instead. ## Test Plan N/A, no functionality/tests affected --- .../flake8_datetimez/rules/datetime_min_max.rs | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/crates/ruff_linter/src/rules/flake8_datetimez/rules/datetime_min_max.rs b/crates/ruff_linter/src/rules/flake8_datetimez/rules/datetime_min_max.rs index 275bc18ba9..a55a91f762 100644 --- a/crates/ruff_linter/src/rules/flake8_datetimez/rules/datetime_min_max.rs +++ b/crates/ruff_linter/src/rules/flake8_datetimez/rules/datetime_min_max.rs @@ -18,19 +18,25 @@ use crate::checkers::ast::Checker; /// unexpectedly, as in: /// /// ```python +/// import datetime +/// /// # Timezone: UTC-14 -/// datetime.min.timestamp() # ValueError: year 0 is out of range -/// datetime.max.timestamp() # ValueError: year 10000 is out of range +/// datetime.datetime.min.timestamp() # ValueError: year 0 is out of range +/// datetime.datetime.max.timestamp() # ValueError: year 10000 is out of range /// ``` /// /// ## Example /// ```python -/// datetime.max +/// import datetime +/// +/// datetime.datetime.max /// ``` /// /// Use instead: /// ```python -/// datetime.max.replace(tzinfo=datetime.UTC) +/// import datetime +/// +/// datetime.datetime.max.replace(tzinfo=datetime.UTC) /// ``` #[derive(ViolationMetadata)] pub(crate) struct DatetimeMinMax {