mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-04 02:38:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Avoid allocation in no-signature (#6375)

Browse source
This commit is contained in:
Charlie Marsh 2023-08-06 11:27:56 -04:00 • committed by GitHub
parent a5a29bb8d6
commit 9171e97d15
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
crates/ruff/src/rules/pydocstyle/rules/no_signature.rs
View file

@ -72,11 +72,14 @@ pub(crate) fn no_signature(checker: &mut Checker, docstring: &Docstring) {
return;
};
if !first_line.contains(&format!("{name}(")) {
return;
};
checker
.diagnostics
.push(Diagnostic::new(NoSignature, docstring.range()));
// Search for occurrences of the function name followed by an open parenthesis (e.g., `foo(` for
// a function named `foo`).
if first_line
.match_indices(name.as_str())
.any(|(index, _)| first_line[index + name.len()..].starts_with('('))
{
checker
.diagnostics
.push(Diagnostic::new(NoSignature, docstring.range()));
}
}