mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 13:51:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[ty] Fix panic when trying to pull types for attribute expressions inside Literal type expressions (#18535)

Browse source
This commit is contained in:
Alex Waygood 2025-06-07 15:59:12 +01:00 • committed by GitHub
parent b3b900dc1e
commit 95497ffaab
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/ty_project/resources/test/corpus/literal_slices.py Normal file
View file

@ -0,0 +1,6 @@
from typing import Literal
class Format:
STRING = "string"
def evaluate(format: Literal[Format.STRING]) -> str: ...

4
crates/ty_project/tests/check.rs
View file

@ -304,18 +304,14 @@ const KNOWN_FAILURES: &[(&str, bool, bool)] = &[
// These are all "expression should belong to this TypeInference region and TypeInferenceBuilder should have inferred a type for it" // These are all "expression should belong to this TypeInference region and TypeInferenceBuilder should have inferred a type for it"
("crates/ty_vendored/vendor/typeshed/stdlib/abc.pyi", true, true), ("crates/ty_vendored/vendor/typeshed/stdlib/abc.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/annotationlib.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/ast.pyi", true, true), ("crates/ty_vendored/vendor/typeshed/stdlib/ast.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/builtins.pyi", true, true), ("crates/ty_vendored/vendor/typeshed/stdlib/builtins.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/curses/__init__.pyi", true, true), ("crates/ty_vendored/vendor/typeshed/stdlib/curses/__init__.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/dataclasses.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/inspect.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/lzma.pyi", true, true), ("crates/ty_vendored/vendor/typeshed/stdlib/lzma.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/os/__init__.pyi", true, true), ("crates/ty_vendored/vendor/typeshed/stdlib/os/__init__.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/pathlib/__init__.pyi", true, true), ("crates/ty_vendored/vendor/typeshed/stdlib/pathlib/__init__.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/pathlib/types.pyi", true, true), ("crates/ty_vendored/vendor/typeshed/stdlib/pathlib/types.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/pstats.pyi", true, true), ("crates/ty_vendored/vendor/typeshed/stdlib/pstats.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/signal.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/socket.pyi", true, true), ("crates/ty_vendored/vendor/typeshed/stdlib/socket.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/sqlite3/__init__.pyi", true, true), ("crates/ty_vendored/vendor/typeshed/stdlib/sqlite3/__init__.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/tempfile.pyi", true, true), ("crates/ty_vendored/vendor/typeshed/stdlib/tempfile.pyi", true, true),

6
crates/ty_python_semantic/src/types/infer.rs
View file

@ -9468,11 +9468,13 @@ impl<'db> TypeInferenceBuilder<'db, '_> {
ast::Expr::Attribute(ast::ExprAttribute { value, attr, .. }) => { ast::Expr::Attribute(ast::ExprAttribute { value, attr, .. }) => {
let value_ty = self.infer_expression(value); let value_ty = self.infer_expression(value);
// TODO: Check that value type is enum otherwise return None // TODO: Check that value type is enum otherwise return None
value_ty let ty = value_ty
.member(self.db(), &attr.id) .member(self.db(), &attr.id)
.place .place
.ignore_possibly_unbound() .ignore_possibly_unbound()
.unwrap_or(Type::unknown()) .unwrap_or(Type::unknown());
self.store_expression_type(parameters, ty);
ty
} }
// for negative and positive numbers // for negative and positive numbers
ast::Expr::UnaryOp(u) ast::Expr::UnaryOp(u)