Introduce an Arguments AST node for function calls and class definitions (#6259)

Browse source

## Summary

This PR adds a new `Arguments` AST node, which we can use for function
calls and class definitions.

The `Arguments` node spans from the left (open) to right (close)
parentheses inclusive.

In the case of classes, the `Arguments` is an option, to differentiate
between:

```python
# None
class C: ...

# Some, with empty vectors
class C(): ...
```

In this PR, we don't really leverage this change (except that a few
rules get much simpler, since we don't need to lex to find the start and
end ranges of the parentheses, e.g.,
`crates/ruff/src/rules/pyupgrade/rules/lru_cache_without_parameters.rs`,
`crates/ruff/src/rules/pyupgrade/rules/unnecessary_class_parentheses.rs`).

In future PRs, this will be especially helpful for the formatter, since
we can track comments enclosed on the node itself.

## Test Plan

`cargo test`

...

This commit is contained in:

Charlie Marsh 2023-08-02 10:01:13 -04:00 • committed by GitHub

parent 0d62ad2480

commit 981e64f82b

No known key found for this signature in database

GPG key ID: 4AEE18F83AFDEB23

107 changed files with 24258 additions and 23835 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

44707

crates/ruff_python_parser/src/python.rs

View file

File diff suppressed because it is too large Load diff