mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-04 10:48:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove deprecated update-check setting (#4313)

Browse source
This commit is contained in:
Charlie Marsh 2023-05-09 13:10:02 -04:00 • committed by GitHub
parent 48e1852893
commit a435c0df4b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 11 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

15
crates/ruff_cli/src/args.rs
View file

@ -240,16 +240,6 @@ pub struct CheckArgs {
/// autofix, even if no lint violations remain.
#[arg(long, help_heading = "Miscellaneous", conflicts_with = "exit_zero")]
pub exit_non_zero_on_fix: bool,
/// Does nothing and will be removed in the future.
#[arg(
long,
overrides_with("no_update_check"),
help_heading = "Miscellaneous",
hide = true
)]
update_check: bool,
#[clap(long, overrides_with("update_check"), hide = true)]
no_update_check: bool,
/// Show counts for every rule with at least one violation.
#[arg(
long,
@ -402,7 +392,6 @@ impl CheckArgs {
force_exclude: resolve_bool_arg(self.force_exclude, self.no_force_exclude),
format: self.format,
show_fixes: resolve_bool_arg(self.show_fixes, self.no_show_fixes),
update_check: resolve_bool_arg(self.update_check, self.no_update_check),
},
)
}
@ -467,7 +456,6 @@ pub struct Overrides {
pub force_exclude: Option<bool>,
pub format: Option<SerializationFormat>,
pub show_fixes: Option<bool>,
pub update_check: Option<bool>,
}
impl ConfigProcessor for &Overrides {
@ -527,9 +515,6 @@ impl ConfigProcessor for &Overrides {
if let Some(target_version) = &self.target_version {
config.target_version = Some(*target_version);
}
if let Some(update_check) = &self.update_check {
config.update_check = Some(*update_check);
}
}
}

8
crates/ruff_cli/src/lib.rs
View file

@ -150,7 +150,6 @@ fn check(args: CheckArgs, log_level: LogLevel) -> Result<ExitStatus> {
fix_only,
format,
show_fixes,
update_check,
..
} = pyproject_config.settings.cli;
@ -311,13 +310,6 @@ fn check(args: CheckArgs, log_level: LogLevel) -> Result<ExitStatus> {
}
}
if update_check {
warn_user_once!(
"update-check has been removed; setting it will cause an error in a future \
version."
);
}
if !cli.exit_zero {
if cli.diff {
// If we're printing a diff, we always want to exit non-zero if there are