mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 22:01:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix documented examples for unnecessary-subscript-reversal (#7774)

Browse source 
## Summary

Two of the three listed examples were wrong: one was semantically
incorrect, another was _correct_ but not actually within the scope of
the rule.

Good motivation for us to start linting documentation examples :)

Closes https://github.com/astral-sh/ruff/issues/7773.
This commit is contained in:
Charlie Marsh 2023-10-03 00:18:49 -04:00 • committed by GitHub
parent e129f77bcf
commit a6ebbf21c3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/ruff_linter/src/checkers/ast/analyze/expression.rs
View file

@ -680,9 +680,7 @@ pub(crate) fn expression(expr: &Expr, checker: &mut Checker) {
);
}
if checker.enabled(Rule::UnnecessarySubscriptReversal) {
flake8_comprehensions::rules::unnecessary_subscript_reversal(
checker, expr, func, args,
);
flake8_comprehensions::rules::unnecessary_subscript_reversal(checker, call);
}
if checker.enabled(Rule::UnnecessaryMap) {
flake8_comprehensions::rules::unnecessary_map(

21
crates/ruff_linter/src/rules/flake8_comprehensions/rules/unnecessary_subscript_reversal.rs
View file

@ -15,16 +15,16 @@ use crate::checkers::ast::Checker;
///
/// ## Examples
/// ```python
/// reversed(iterable[::-1])
/// sorted(iterable[::-1])
/// set(iterable[::-1])
/// sorted(iterable)[::-1]
/// reversed(iterable[::-1])
/// ```
///
/// Use instead:
/// ```python
/// reversed(iterable)
/// sorted(iterable)
/// set(iterable)
/// sorted(iterable, reverse=True)
/// iterable
/// ```
#[violation]
pub struct UnnecessarySubscriptReversal {
@ -40,16 +40,11 @@ impl Violation for UnnecessarySubscriptReversal {
}
/// C415
pub(crate) fn unnecessary_subscript_reversal(
checker: &mut Checker,
expr: &Expr,
func: &Expr,
args: &[Expr],
) {
let Some(first_arg) = args.first() else {
pub(crate) fn unnecessary_subscript_reversal(checker: &mut Checker, call: &ast::ExprCall) {
let Some(first_arg) = call.arguments.args.first() else {
return;
};
let Some(func) = func.as_name_expr() else {
let Some(func) = call.func.as_name_expr() else {
return;
};
if !matches!(func.id.as_str(), "reversed" | "set" | "sorted") {
@ -98,6 +93,6 @@ pub(crate) fn unnecessary_subscript_reversal(
UnnecessarySubscriptReversal {
func: func.id.to_string(),
},
expr.range(),
call.range(),
));
}