mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-29 21:34:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[ty] Use full range for assignment definitions (#19211)

Browse source 
## Summary

Fix the `full_range` function for (annotated) assignment definition
kinds.

## Test Plan

Update snapshot tests
This commit is contained in:
David Peter 2025-07-08 19:51:09 +02:00 • committed by GitHub
parent fda188953f
commit a8f2c26143
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 17 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ty_python_semantic/resources/mdtest/snapshots/final.md_-_`typing.Final`_-_Full_diagnostics_(174fdd8134fb325b).snap
View file

@ -30,7 +30,7 @@ error[invalid-assignment]: Reassignment of `Final` symbol `MY_CONSTANT` is not a
1 | from typing import Final
2 |
3 | MY_CONSTANT: Final[int] = 1
| ----------- Original definition
| --------------------------- Original definition
4 |
5 | # more code
6 |

2
crates/ty_python_semantic/resources/mdtest/snapshots/functions.md_-_Generic_functions___L…_-_Inferring_a_bound_ty…_(d50204b9d91b7bd1).snap
View file

@ -82,7 +82,7 @@ info: Type variable defined here
2 | from typing_extensions import reveal_type
3 |
4 | T = TypeVar("T", bound=int)
| ^
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
5 |
6 | def f(x: T) -> T:
|

2
crates/ty_python_semantic/resources/mdtest/snapshots/functions.md_-_Generic_functions___L…_-_Inferring_a_constrai…_(48ab83f977c109b4).snap
View file

@ -97,7 +97,7 @@ info: Type variable defined here
2 | from typing_extensions import reveal_type
3 |
4 | T = TypeVar("T", int, None)
| ^
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
5 |
6 | def f(x: T) -> T:
|

16
crates/ty_python_semantic/src/semantic_index/definition.rs
View file

@ -677,8 +677,20 @@ impl DefinitionKind<'_> {
DefinitionKind::Class(class) => class.node(module).range(),
DefinitionKind::TypeAlias(type_alias) => type_alias.node(module).range(),
DefinitionKind::NamedExpression(named) => named.node(module).range(),
DefinitionKind::Assignment(assignment) => assignment.target.node(module).range(),
DefinitionKind::AnnotatedAssignment(assign) => assign.target.node(module).range(),
DefinitionKind::Assignment(assign) => {
let target_range = assign.target.node(module).range();
let value_range = assign.value.node(module).range();
target_range.cover(value_range)
}
DefinitionKind::AnnotatedAssignment(assign) => {
let target_range = assign.target.node(module).range();
if let Some(ref value) = assign.value {
let value_range = value.node(module).range();
target_range.cover(value_range)
} else {
target_range
}
}
DefinitionKind::AugmentedAssignment(aug_assign) => aug_assign.node(module).range(),
DefinitionKind::For(for_stmt) => for_stmt.target.node(module).range(),
DefinitionKind::Comprehension(comp) => comp.target(module).range(),