mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-06 00:20:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ruff_db: add a vector for configuring diagnostic output (#16118)

Browse source 
For now, the only thing one can configure is whether color is enabled or
not. This avoids needing to ask the `colored` crate whether colors have
been globally enabled or disabled. And, more crucially, avoids the need
to _set_ this global flag for testing diagnostic output. Doing so can
have unintended consequences, as outlined in #16115.

Fixes #16115
This commit is contained in:
Andrew Gallant 2025-02-12 09:38:05 -05:00 • committed by GitHub
parent 03f08283ad
commit a9671e7008
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 38 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/red_knot_wasm/src/lib.rs
View file

@ -7,7 +7,7 @@ use red_knot_project::metadata::options::{EnvironmentOptions, Options};
use red_knot_project::metadata::value::RangedValue;
use red_knot_project::ProjectMetadata;
use red_knot_project::{Db, ProjectDatabase};
use ruff_db::diagnostic::Diagnostic;
use ruff_db::diagnostic::{Diagnostic, DisplayDiagnosticConfig};
use ruff_db::files::{system_path_to_file, File};
use ruff_db::system::walk_directory::WalkDirectoryBuilder;
use ruff_db::system::{
@ -114,9 +114,10 @@ impl Workspace {
pub fn check_file(&self, file_id: &FileHandle) -> Result<Vec<String>, Error> {
let result = self.db.check_file(file_id.file).map_err(into_error)?;
let display_config = DisplayDiagnosticConfig::default().color(false);
Ok(result
.into_iter()
.map(|diagnostic| diagnostic.display(&self.db).to_string())
.map(|diagnostic| diagnostic.display(&self.db, &display_config).to_string())
.collect())
}
@ -124,9 +125,10 @@ impl Workspace {
pub fn check(&self) -> Result<Vec<String>, Error> {
let result = self.db.check().map_err(into_error)?;
let display_config = DisplayDiagnosticConfig::default().color(false);
Ok(result
.into_iter()
.map(|diagnostic| diagnostic.display(&self.db).to_string())
.map(|diagnostic| diagnostic.display(&self.db, &display_config).to_string())
.collect())
}