mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-27 04:19:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[ruff] - fix false positive for decorators (RUF028) (#14061)

Browse source
This commit is contained in:
Steve C 2024-11-03 06:49:03 -05:00 • committed by GitHub
parent f69712c11d
commit ae9f08d1e5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
crates/ruff_linter/resources/test/fixtures/ruff/RUF028.py vendored
View file

@ -87,3 +87,17 @@ def match_case_and_elif():
pass pass
elif string == "Hello": # fmt: skip elif string == "Hello": # fmt: skip
pass pass
# Regression test for decorators
import pytest
@pytest.mark.parametrize(
"test_input,expected",
[
("3+5", 8 ),
("17+2", 19),
],
) # fmt: skip
def test_eval(test_input, expected):
assert eval(test_input) == expected

2
crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs
View file

@ -278,6 +278,7 @@ const fn is_valid_enclosing_node(node: AnyNodeRef) -> bool {
| AnyNodeRef::StmtIpyEscapeCommand(_) | AnyNodeRef::StmtIpyEscapeCommand(_)
| AnyNodeRef::ExceptHandlerExceptHandler(_) | AnyNodeRef::ExceptHandlerExceptHandler(_)
| AnyNodeRef::MatchCase(_) | AnyNodeRef::MatchCase(_)
| AnyNodeRef::Decorator(_)
| AnyNodeRef::ElifElseClause(_) => true, | AnyNodeRef::ElifElseClause(_) => true,
AnyNodeRef::ExprBoolOp(_) AnyNodeRef::ExprBoolOp(_)
@ -333,7 +334,6 @@ const fn is_valid_enclosing_node(node: AnyNodeRef) -> bool {
| AnyNodeRef::Keyword(_) | AnyNodeRef::Keyword(_)
| AnyNodeRef::Alias(_) | AnyNodeRef::Alias(_)
| AnyNodeRef::WithItem(_) | AnyNodeRef::WithItem(_)
| AnyNodeRef::Decorator(_)
| AnyNodeRef::TypeParams(_) | AnyNodeRef::TypeParams(_)
| AnyNodeRef::TypeParamTypeVar(_) | AnyNodeRef::TypeParamTypeVar(_)
| AnyNodeRef::TypeParamTypeVarTuple(_) | AnyNodeRef::TypeParamTypeVarTuple(_)