mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-03 10:22:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[refurb] Use UserString instead of non-existent UserStr (#14209)

Browse source 
## Summary

The class name is UserString, not a UserStr, see
https://docs.python.org/3.9/library/collections.html#collections.UserString
This commit is contained in:
Michal Čihař 2024-11-09 02:54:18 +01:00 • committed by GitHub
parent de947deee7
commit b19f388249
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/ruff_linter/src/rules/refurb/rules/subclass_builtin.rs
View file

@ -10,7 +10,7 @@ use crate::{checkers::ast::Checker, importer::ImportRequest};
///
/// ## Why is this bad?
/// Subclassing `dict`, `list`, or `str` objects can be error prone, use the
/// `UserDict`, `UserList`, and `UserStr` objects from the `collections` module
/// `UserDict`, `UserList`, and `UserString` objects from the `collections` module
/// instead.
///
/// ## Example
@ -124,7 +124,7 @@ impl SupportedBuiltins {
match self {
SupportedBuiltins::Dict => "UserDict",
SupportedBuiltins::List => "UserList",
SupportedBuiltins::Str => "UserStr",
SupportedBuiltins::Str => "UserString",
}
}
}

8
crates/ruff_linter/src/rules/refurb/snapshots/ruff_linter__rules__refurb__tests__FURB189_FURB189.py.snap
View file

@ -48,7 +48,7 @@ FURB189.py:20:9: FURB189 [*] Subclassing `list` can be error prone, use `collect
22 22 |
23 23 | class S(str):
FURB189.py:23:9: FURB189 [*] Subclassing `str` can be error prone, use `collections.UserStr` instead
FURB189.py:23:9: FURB189 [*] Subclassing `str` can be error prone, use `collections.UserString` instead
|
21 | pass
22 |
@ -56,13 +56,13 @@ FURB189.py:23:9: FURB189 [*] Subclassing `str` can be error prone, use `collecti
| ^^^ FURB189
24 | pass
|
= help: Replace with `collections.UserStr`
= help: Replace with `collections.UserString`
ℹ Unsafe fix
1 1 | # setup
2 2 | from enum import Enum, EnumMeta
3 |-from collections import UserList as UL
3 |+from collections import UserList as UL, UserStr
3 |+from collections import UserList as UL, UserString
4 4 |
5 5 | class SetOnceMappingMixin:
6 6 | __slots__ = ()
@ -71,7 +71,7 @@ FURB189.py:23:9: FURB189 [*] Subclassing `str` can be error prone, use `collecti
21 21 | pass
22 22 |
23 |-class S(str):
23 |+class S(UserStr):
23 |+class S(UserString):
24 24 | pass
25 25 |
26 26 | # currently not detected