mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-01 14:21:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

[ty] Add rule link to server diagnostics (#18128)

Browse source 
Co-authored-by: Micha Reiser <micha@reiser.io>
This commit is contained in:
Chandra Kiran G 2025-05-17 22:57:59 +05:30 • committed by GitHub
parent 2abcd86c57
commit b86960f18c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

17
crates/ty_server/src/server/api/requests/diagnostic.rs
View file

@ -4,7 +4,7 @@ use lsp_types::request::DocumentDiagnosticRequest;
use lsp_types::{ use lsp_types::{
Diagnostic, DiagnosticSeverity, DiagnosticTag, DocumentDiagnosticParams, Diagnostic, DiagnosticSeverity, DiagnosticTag, DocumentDiagnosticParams,
DocumentDiagnosticReport, DocumentDiagnosticReportResult, FullDocumentDiagnosticReport, DocumentDiagnosticReport, DocumentDiagnosticReportResult, FullDocumentDiagnosticReport,
NumberOrString, Range, RelatedFullDocumentDiagnosticReport, Url, NumberOrString, Range, RelatedFullDocumentDiagnosticReport,
}; };
use crate::document::ToRangeExt; use crate::document::ToRangeExt;
@ -22,7 +22,7 @@ impl RequestHandler for DocumentDiagnosticRequestHandler {
} }
impl BackgroundDocumentRequestHandler for DocumentDiagnosticRequestHandler { impl BackgroundDocumentRequestHandler for DocumentDiagnosticRequestHandler {
fn document_url(params: &DocumentDiagnosticParams) -> Cow<Url> { fn document_url(params: &DocumentDiagnosticParams) -> Cow<lsp_types::Url> {
Cow::Borrowed(&params.text_document.uri) Cow::Borrowed(&params.text_document.uri)
} }
@ -105,12 +105,23 @@ fn to_lsp_diagnostic(
}) })
.filter(|mapped_tags| !mapped_tags.is_empty()); .filter(|mapped_tags| !mapped_tags.is_empty());
let code_description = diagnostic
.id()
.is_lint()
.then(|| {
Some(lsp_types::CodeDescription {
href: lsp_types::Url::parse(&format!("https://ty.dev/rules#{}", diagnostic.id()))
.ok()?,
})
})
.flatten();
Diagnostic { Diagnostic {
range, range,
severity: Some(severity), severity: Some(severity),
tags, tags,
code: Some(NumberOrString::String(diagnostic.id().to_string())), code: Some(NumberOrString::String(diagnostic.id().to_string())),
code_description: None, code_description,
source: Some("ty".into()), source: Some("ty".into()),
message: diagnostic.concise_message().to_string(), message: diagnostic.concise_message().to_string(),
related_information: None, related_information: None,