mirror of
https://github.com/astral-sh/ruff.git
synced 2025-07-26 22:43:47 +00:00
Fix remaining CPython formatter errors except for function argument separator comments (#5210)
## Summary This fixes two problems discovered when trying to format the cpython repo with `cargo run --bin ruff_dev -- check-formatter-stability projects/cpython`: The first is to ignore try/except trailing comments for now since they lead to unstable formatting on the dummy. The second is to avoid dropping trailing if comments through placement: This changes the placement to keep a comment trailing an if-elif or if-elif-else to keep the comment a trailing comment on the entire if. Previously the last comment would have been lost. ```python if "first if": pass elif "first elif": pass ``` The last remaining problem in cpython so far is function signature argument separator comment placement which is its own PR on top of this. ## Test Plan I added test fixtures of minimized examples with links back to the original cpython location
This commit is contained in:
parent
bf1a94ee54
commit
bc63cc9b3c
6 changed files with 148 additions and 34 deletions
|
@ -9,4 +9,9 @@ impl FormatNodeRule<StmtTry> for FormatStmtTry {
|
|||
fn fmt_fields(&self, item: &StmtTry, f: &mut PyFormatter) -> FormatResult<()> {
|
||||
write!(f, [not_yet_implemented(item)])
|
||||
}
|
||||
|
||||
fn fmt_dangling_comments(&self, _node: &StmtTry, _f: &mut PyFormatter) -> FormatResult<()> {
|
||||
// TODO(konstin): Needs node formatting or this leads to unstable formatting
|
||||
Ok(())
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue