mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-21 17:50:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Detect automagic-like assignments in notebooks (#9653)

Browse source 
## Summary

Given a statement like `colors = 6`, we currently treat the cell as an
automagic (since `colors` is an automagic) -- i.e., we assume it's
equivalent to `%colors = 6`. This PR adds some additional detection
whereby if the statement is an _assignment_, we avoid treating it as
such. I audited the list of automagics, and I believe this is safe for
all of them.

Closes https://github.com/astral-sh/ruff/issues/8526.

Closes https://github.com/astral-sh/ruff/issues/9648.

## Test Plan

`cargo test`
This commit is contained in:
Charlie Marsh 2024-01-29 04:55:44 -08:00 • committed by GitHub
parent c8074b0e18
commit bea8f2ee3a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 113 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

1
crates/ruff_notebook/src/notebook.rs
View file

@ -454,6 +454,7 @@ mod tests {
#[test_case("cell_magic", false)]
#[test_case("valid_cell_magic", true)]
#[test_case("automagic", false)]
#[test_case("automagic_assignment", true)]
#[test_case("automagics", false)]
#[test_case("automagic_before_code", false)]
#[test_case("automagic_after_code", true)]