mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-01 06:11:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Remove unnecessary mutable variable has_parameters (#8124)

Browse source
This commit is contained in:
Harutaka Kawamura 2023-10-23 15:09:33 +09:00 • committed by GitHub
parent 2c2ebf952a
commit c0710a1dd4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

17
crates/ruff_linter/src/rules/flake8_pytest_style/rules/marks.rs
View file

@ -167,24 +167,25 @@ fn check_useless_usefixtures(checker: &mut Checker, decorator: &Decorator, marke
return; return;
} }
let mut has_parameters = false; match &decorator.expression {
// @pytest.mark.usefixtures
if let Expr::Call(ast::ExprCall { Expr::Attribute(..) => {}
// @pytest.mark.usefixtures(...)
Expr::Call(ast::ExprCall {
arguments: Arguments { args, keywords, .. }, arguments: Arguments { args, keywords, .. },
.. ..
}) = &decorator.expression }) => {
{
if !args.is_empty() || !keywords.is_empty() { if !args.is_empty() || !keywords.is_empty() {
has_parameters = true; return;
} }
} }
_ => return,
}
if !has_parameters {
let mut diagnostic = Diagnostic::new(PytestUseFixturesWithoutParameters, decorator.range()); let mut diagnostic = Diagnostic::new(PytestUseFixturesWithoutParameters, decorator.range());
diagnostic.set_fix(Fix::unsafe_edit(Edit::range_deletion(decorator.range()))); diagnostic.set_fix(Fix::unsafe_edit(Edit::range_deletion(decorator.range())));
checker.diagnostics.push(diagnostic); checker.diagnostics.push(diagnostic);
} }
}
pub(crate) fn marks(checker: &mut Checker, decorators: &[Decorator]) { pub(crate) fn marks(checker: &mut Checker, decorators: &[Decorator]) {
let enforce_parentheses = checker.enabled(Rule::PytestIncorrectMarkParenthesesStyle); let enforce_parentheses = checker.enabled(Rule::PytestIncorrectMarkParenthesesStyle);