mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 05:44:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove ecosystem_ci flag from Ruff CLI (#12596)

Browse source 
## Summary

@zanieb noticed while we were discussing #12595 that this flag is now
unnecessary, so remove it and the flags which reference it.

## Test Plan

Question for maintainers: is there a test to add *or* remove here? (I’ve
opened this as a draft PR with that in view!)
This commit is contained in:
Chris Krycho 2024-07-31 10:40:03 -06:00 • committed by GitHub
parent a44d579f21
commit c1bc7f4dee
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 2 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/ruff/src/args.rs
View file

@ -400,9 +400,6 @@ pub struct CheckCommand {
conflicts_with = "watch", conflicts_with = "watch",
)] )]
pub show_settings: bool, pub show_settings: bool,
/// Dev-only argument to show fixes
#[arg(long, hide = true)]
pub ecosystem_ci: bool,
} }
#[derive(Clone, Debug, clap::Parser)] #[derive(Clone, Debug, clap::Parser)]
@ -662,7 +659,6 @@ impl CheckCommand {
let check_arguments = CheckArguments { let check_arguments = CheckArguments {
add_noqa: self.add_noqa, add_noqa: self.add_noqa,
diff: self.diff, diff: self.diff,
ecosystem_ci: self.ecosystem_ci,
exit_non_zero_on_fix: self.exit_non_zero_on_fix, exit_non_zero_on_fix: self.exit_non_zero_on_fix,
exit_zero: self.exit_zero, exit_zero: self.exit_zero,
files: self.files, files: self.files,
@ -946,7 +942,6 @@ fn resolve_output_format(
pub struct CheckArguments { pub struct CheckArguments {
pub add_noqa: bool, pub add_noqa: bool,
pub diff: bool, pub diff: bool,
pub ecosystem_ci: bool,
pub exit_non_zero_on_fix: bool, pub exit_non_zero_on_fix: bool,
pub exit_zero: bool, pub exit_zero: bool,
pub files: Vec<PathBuf>, pub files: Vec<PathBuf>,

7
crates/ruff/src/lib.rs
View file

@ -287,13 +287,6 @@ pub fn check(args: CheckCommand, global_options: GlobalConfigArgs) -> Result<Exi
if show_fixes { if show_fixes {
printer_flags |= PrinterFlags::SHOW_FIX_SUMMARY; printer_flags |= PrinterFlags::SHOW_FIX_SUMMARY;
} }
if cli.ecosystem_ci {
warn_user!(
"The formatting of fixes emitted by this option is a work-in-progress, subject to \
change at any time, and intended only for internal use."
);
printer_flags |= PrinterFlags::SHOW_FIX_DIFF;
}
#[cfg(debug_assertions)] #[cfg(debug_assertions)]
if cache { if cache {

2
python/ruff-ecosystem/ruff_ecosystem/projects.py
View file

@ -221,7 +221,7 @@ class CheckOptions(CommandOptions):
if self.exclude: if self.exclude:
args.extend(["--exclude", self.exclude]) args.extend(["--exclude", self.exclude])
if self.show_fixes: if self.show_fixes:
args.extend(["--show-fixes", "--ecosystem-ci"]) args.extend(["--show-fixes"])
return args return args

2
scripts/check_ecosystem.py
View file

@ -191,7 +191,7 @@ async def check(
if exclude: if exclude:
ruff_args.extend(["--exclude", exclude]) ruff_args.extend(["--exclude", exclude])
if show_fixes: if show_fixes:
ruff_args.extend(["--show-fixes", "--ecosystem-ci"]) ruff_args.extend(["--show-fixes"])
start = time.time() start = time.time()
proc = await create_subprocess_exec( proc = await create_subprocess_exec(