mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-29 13:24:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[ty] support type aliases in binary compares (#20445)

Browse source 
## Summary

Add missing `Type::TypeAlias` clauses to `infer_binary_type_comparison`.

## Test Plan

Added mdtests that failed before.
This commit is contained in:
Carl Meyer 2025-09-17 00:33:26 -07:00 • committed by GitHub
parent 681ad2fd92
commit c2fa449954
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 26 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crates/ty_python_semantic/resources/mdtest/pep695_type_aliases.md
View file

@ -137,6 +137,18 @@ from ty_extensions import is_equivalent_to, static_assert
static_assert(is_equivalent_to(Y, A | B | C | D)) static_assert(is_equivalent_to(Y, A | B | C | D))
``` ```
## In binary ops
```py
from typing import Literal
type X = tuple[Literal[1], Literal[2]]
def _(x: X, y: tuple[Literal[1], Literal[3]]):
reveal_type(x == y) # revealed: Literal[False]
reveal_type(x < y) # revealed: Literal[True]
```
## `TypeAliasType` properties ## `TypeAliasType` properties
Two `TypeAliasType`s are distinct and disjoint, even if they refer to the same type Two `TypeAliasType`s are distinct and disjoint, even if they refer to the same type

14
crates/ty_python_semantic/src/types/infer/builder.rs
View file

@ -7721,6 +7721,20 @@ impl<'db, 'ast> TypeInferenceBuilder<'db, 'ast> {
)) ))
} }
(Type::TypeAlias(alias), right) => Some(self.infer_binary_type_comparison(
alias.value_type(self.db()),
op,
right,
range,
)),
(left, Type::TypeAlias(alias)) => Some(self.infer_binary_type_comparison(
left,
op,
alias.value_type(self.db()),
range,
)),
(Type::IntLiteral(n), Type::IntLiteral(m)) => Some(match op { (Type::IntLiteral(n), Type::IntLiteral(m)) => Some(match op {
ast::CmpOp::Eq => Ok(Type::BooleanLiteral(n == m)), ast::CmpOp::Eq => Ok(Type::BooleanLiteral(n == m)),
ast::CmpOp::NotEq => Ok(Type::BooleanLiteral(n != m)), ast::CmpOp::NotEq => Ok(Type::BooleanLiteral(n != m)),