Add our own ignored-names abstractions (#9802)

## Summary

These run over nearly every identifier. It's rare to override them, so
when not provided, we can just use a match against the hardcoded default
set.
This commit is contained in:
Charlie Marsh 2024-02-03 06:48:07 -08:00 committed by GitHub
parent 2352de2277
commit c53aae0b6f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
19 changed files with 248 additions and 185 deletions

View file

@ -15,6 +15,7 @@ use ruff_linter::rules::flake8_quotes::settings::Quote;
use ruff_linter::rules::flake8_tidy_imports::settings::{ApiBan, Strictness};
use ruff_linter::rules::isort::settings::RelativeImportsOrder;
use ruff_linter::rules::isort::{ImportSection, ImportType};
use ruff_linter::rules::pep8_naming::settings::IgnoreNames;
use ruff_linter::rules::pydocstyle::settings::Convention;
use ruff_linter::rules::pylint::settings::ConstantType;
use ruff_linter::rules::{
@ -2511,16 +2512,7 @@ impl Pep8NamingOptions {
self,
) -> Result<pep8_naming::settings::Settings, pep8_naming::settings::SettingsError> {
Ok(pep8_naming::settings::Settings {
ignore_names: self
.ignore_names
.unwrap_or_else(pep8_naming::settings::default_ignore_names)
.into_iter()
.chain(self.extend_ignore_names.unwrap_or_default())
.map(|name| {
IdentifierPattern::new(&name)
.map_err(pep8_naming::settings::SettingsError::InvalidIgnoreName)
})
.collect::<Result<Vec<_>, pep8_naming::settings::SettingsError>>()?,
ignore_names: IgnoreNames::from_options(self.ignore_names, self.extend_ignore_names)?,
classmethod_decorators: self.classmethod_decorators.unwrap_or_default(),
staticmethod_decorators: self.staticmethod_decorators.unwrap_or_default(),
})