From c5e41c278cec292461214e9df32f75926f90ba0f Mon Sep 17 00:00:00 2001 From: Vasco Schiavo <115561717+VascoSch92@users.noreply.github.com> Date: Wed, 30 Apr 2025 21:06:25 +0200 Subject: [PATCH] [`ruff`] Add fix safety section (`RUF028`) (#17722) The PR add the fix safety section for rule `RUF028` (https://github.com/astral-sh/ruff/issues/15584 ) See also [here](https://github.com/astral-sh/ruff/issues/15584#issuecomment-2820424485) for the reason behind the _unsafe_ of the fix. --- .../ruff/rules/invalid_formatter_suppression_comment.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs b/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs index b3fac6e6ca..2293071d0e 100644 --- a/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs +++ b/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs @@ -49,6 +49,12 @@ use super::suppression_comment_visitor::{ /// # fmt: on /// # yapf: enable /// ``` +/// +/// ## Fix safety +/// +/// This fix is always marked as unsafe because it deletes the invalid suppression comment, +/// rather than trying to move it to a valid position, which the user more likely intended. +/// #[derive(ViolationMetadata)] pub(crate) struct InvalidFormatterSuppressionComment { reason: IgnoredReason,