From c9b2bcbfb28130c278ff78a53b86822623e71dcf Mon Sep 17 00:00:00 2001 From: Brent Westbrook <36778786+ntBre@users.noreply.github.com> Date: Thu, 2 Oct 2025 14:47:15 -0400 Subject: [PATCH] Update benchmarking CI for cargo-codspeed v4 (#20686) Summary -- A new codspeed [release](https://github.com/CodSpeedHQ/codspeed-rust/releases/tag/v4.0.0) came out, and our CI was failing. It looks like the previously-positional list of benchmarks now corresponds to a `--bench` [flag](https://github.com/CodSpeedHQ/codspeed-rust/blob/7159cf86b9432243565e488c827c1663b5385fde/crates/cargo-codspeed/src/app.rs#L39-L43). Test Plan -- CI on this PR ## TODO - [x] Drop whitespace change commit, just wanted to make sure the benchmarks ran --- .github/workflows/ci.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 83332187bc..578eeb1be7 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -932,7 +932,7 @@ jobs: tool: cargo-codspeed - name: "Build benchmarks" - run: cargo codspeed build --features "codspeed,instrumented" --no-default-features -p ruff_benchmark formatter lexer linter parser + run: cargo codspeed build --features "codspeed,instrumented" --no-default-features -p ruff_benchmark --bench formatter --bench lexer --bench linter --bench parser - name: "Run benchmarks" uses: CodSpeedHQ/action@653fdc30e6c40ffd9739e40c8a0576f4f4523ca1 # v4.0.1 @@ -967,7 +967,7 @@ jobs: tool: cargo-codspeed - name: "Build benchmarks" - run: cargo codspeed build --features "codspeed,instrumented" --no-default-features -p ruff_benchmark ty + run: cargo codspeed build --features "codspeed,instrumented" --no-default-features -p ruff_benchmark --bench ty - name: "Run benchmarks" uses: CodSpeedHQ/action@653fdc30e6c40ffd9739e40c8a0576f4f4523ca1 # v4.0.1