mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-29 13:24:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[red-knot] Do not use explicit knot_extensions.Unknown declaration (#15787)

Browse source 
## Summary

Do not use an explict `knot_extensions.Unknown` declaration, as per
[this
comment](https://github.com/astral-sh/ruff/pull/15766#discussion_r1930997592).
Instead, use an undefined name to achieve the same effect.
This commit is contained in:
David Peter 2025-01-28 17:18:22 +01:00 • committed by GitHub
parent 98d20a8219
commit ca53eefa6f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

15
crates/red_knot_python_semantic/resources/mdtest/boundness_declaredness/public.md
View file

@ -202,17 +202,16 @@ a = None
### Undeclared but bound
If a symbols is undeclared, we use the union of `Unknown` with the inferred type. Note that we treat
symbols that are undeclared differently from symbols that are explicitly declared as `Unknown`:
If a symbol is *undeclared*, we use the union of `Unknown` with the inferred type. Note that we
treat this case differently from the case where a symbol is implicitly declared with `Unknown`,
possibly due to the usage of an unknown name in the annotation:
```py path=mod.py
from knot_extensions import Unknown
# Undeclared:
a = 1
# Declared with `Unknown`:
b: Unknown = 1
# Implicitly declared with `Unknown`, due to the usage of an unknown name in the annotation:
b: SomeUnknownName = 1 # error: [unresolved-reference]
```
```py
@ -231,13 +230,11 @@ If a symbol is undeclared and *possibly* unbound, we currently do not raise an e
inconsistent when compared to the "possibly-undeclared-and-possibly-unbound" case.
```py path=mod.py
from knot_extensions import Unknown
def flag() -> bool: ...
if flag:
a = 1
b: Unknown = 1
b: SomeUnknownName = 1 # error: [unresolved-reference]
```
```py

2
crates/red_knot_test/README.md
View file

@ -283,7 +283,7 @@ cargo test -p red_knot_python_semantic -- mdtest__
Alternatively, you can use the `mdtest.py` runner which has a watch mode that will re-run corresponding tests when Markdown files change, and recompile automatically when Rust code changes:
```bash
uv -q run crates/red_knot_python_semantic/mdtest.py
uv run crates/red_knot_python_semantic/mdtest.py
```
## Planned features