mirror of
https://github.com/astral-sh/ruff.git
synced 2025-10-03 15:14:42 +00:00
[ty]eliminate definitely-impossible types from union in equality narrowing (#20164)
Some checks are pending
CI / test ruff-lsp (push) Blocked by required conditions
CI / mkdocs (push) Waiting to run
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / Fuzz for new ty panics (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / check playground (push) Blocked by required conditions
CI / benchmarks-instrumented (push) Blocked by required conditions
CI / benchmarks-walltime (push) Blocked by required conditions
[ty Playground] Release / publish (push) Waiting to run
Some checks are pending
CI / test ruff-lsp (push) Blocked by required conditions
CI / mkdocs (push) Waiting to run
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / Fuzz for new ty panics (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / check playground (push) Blocked by required conditions
CI / benchmarks-instrumented (push) Blocked by required conditions
CI / benchmarks-walltime (push) Blocked by required conditions
[ty Playground] Release / publish (push) Waiting to run
solves https://github.com/astral-sh/ty/issues/939 --------- Co-authored-by: Carl Meyer <carl@astral.sh>
This commit is contained in:
parent
b14fc96141
commit
cda376afe0
3 changed files with 193 additions and 26 deletions
|
@ -92,3 +92,106 @@ if (x := f()) in (1,):
|
|||
else:
|
||||
reveal_type(x) # revealed: Literal[2, 3]
|
||||
```
|
||||
|
||||
## Union with `Literal`, `None` and `int`
|
||||
|
||||
```py
|
||||
from typing import Literal
|
||||
|
||||
def test(x: Literal["a", "b", "c"] | None | int = None):
|
||||
if x in ("a", "b"):
|
||||
# int is included because custom __eq__ methods could make
|
||||
# an int equal to "a" or "b", so we can't eliminate it
|
||||
reveal_type(x) # revealed: Literal["a", "b"] | int
|
||||
else:
|
||||
reveal_type(x) # revealed: Literal["c"] | None | int
|
||||
```
|
||||
|
||||
## Direct `not in` conditional
|
||||
|
||||
```py
|
||||
from typing import Literal
|
||||
|
||||
def test(x: Literal["a", "b", "c"] | None | int = None):
|
||||
if x not in ("a", "c"):
|
||||
# int is included because custom __eq__ methods could make
|
||||
# an int equal to "a" or "b", so we can't eliminate it
|
||||
reveal_type(x) # revealed: Literal["b"] | None | int
|
||||
else:
|
||||
reveal_type(x) # revealed: Literal["a", "c"] | int
|
||||
```
|
||||
|
||||
## bool
|
||||
|
||||
```py
|
||||
def _(x: bool):
|
||||
if x in (True,):
|
||||
reveal_type(x) # revealed: Literal[True]
|
||||
else:
|
||||
reveal_type(x) # revealed: Literal[False]
|
||||
|
||||
def _(x: bool | str):
|
||||
if x in (False,):
|
||||
# `str` remains due to possible custom __eq__ methods on a subclass
|
||||
reveal_type(x) # revealed: Literal[False] | str
|
||||
else:
|
||||
reveal_type(x) # revealed: Literal[True] | str
|
||||
```
|
||||
|
||||
## LiteralString
|
||||
|
||||
```py
|
||||
from typing_extensions import LiteralString
|
||||
|
||||
def _(x: LiteralString):
|
||||
if x in ("a", "b", "c"):
|
||||
reveal_type(x) # revealed: Literal["a", "b", "c"]
|
||||
else:
|
||||
reveal_type(x) # revealed: LiteralString & ~Literal["a"] & ~Literal["b"] & ~Literal["c"]
|
||||
|
||||
def _(x: LiteralString | int):
|
||||
if x in ("a", "b", "c"):
|
||||
reveal_type(x) # revealed: Literal["a", "b", "c"] | int
|
||||
else:
|
||||
reveal_type(x) # revealed: (LiteralString & ~Literal["a"] & ~Literal["b"] & ~Literal["c"]) | int
|
||||
```
|
||||
|
||||
## enums
|
||||
|
||||
```py
|
||||
from enum import Enum
|
||||
|
||||
class Color(Enum):
|
||||
RED = "red"
|
||||
GREEN = "green"
|
||||
BLUE = "blue"
|
||||
|
||||
def _(x: Color):
|
||||
if x in (Color.RED, Color.GREEN):
|
||||
# TODO should be `Literal[Color.RED, Color.GREEN]`
|
||||
reveal_type(x) # revealed: Color
|
||||
else:
|
||||
# TODO should be `Literal[Color.BLUE]`
|
||||
reveal_type(x) # revealed: Color
|
||||
```
|
||||
|
||||
## Union with enum and `int`
|
||||
|
||||
```py
|
||||
from enum import Enum
|
||||
|
||||
class Status(Enum):
|
||||
PENDING = 1
|
||||
APPROVED = 2
|
||||
REJECTED = 3
|
||||
|
||||
def test(x: Status | int):
|
||||
if x in (Status.PENDING, Status.APPROVED):
|
||||
# TODO should be `Literal[Status.PENDING, Status.APPROVED] | int`
|
||||
# int is included because custom __eq__ methods could make
|
||||
# an int equal to Status.PENDING or Status.APPROVED, so we can't eliminate it
|
||||
reveal_type(x) # revealed: Status | int
|
||||
else:
|
||||
# TODO should be `Literal[Status.REJECTED] | int`
|
||||
reveal_type(x) # revealed: Status | int
|
||||
```
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue