From d545b5bfd2eaf67fbbdae8e3af7855276160c79c Mon Sep 17 00:00:00 2001 From: Yunchi Pang Date: Mon, 12 May 2025 13:27:54 -0700 Subject: [PATCH] [`pylint`] add fix safety section (`PLE4703`) (#17824) This PR adds a fix safety section in comment for rule PLE4703. parent: #15584 impl was introduced at #970 (couldn't find newer PRs sorry!) --- .../src/rules/pylint/rules/modified_iterating_set.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/crates/ruff_linter/src/rules/pylint/rules/modified_iterating_set.rs b/crates/ruff_linter/src/rules/pylint/rules/modified_iterating_set.rs index 84bb50f073..f9e5f17a67 100644 --- a/crates/ruff_linter/src/rules/pylint/rules/modified_iterating_set.rs +++ b/crates/ruff_linter/src/rules/pylint/rules/modified_iterating_set.rs @@ -38,6 +38,11 @@ use crate::checkers::ast::Checker; /// nums.add(num + 5) /// ``` /// +/// ## Fix safety +/// This fix is always unsafe because it changes the program’s behavior. Replacing the +/// original set with a copy during iteration allows code that would previously raise a +/// `RuntimeError` to run without error. +/// /// ## References /// - [Python documentation: `set`](https://docs.python.org/3/library/stdtypes.html#set) #[derive(ViolationMetadata)]