mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-07-22 20:45:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove some allocations in argument detection (#5481)

Browse source 
## Summary

Drive-by PR to remove some allocations around argument name matching.
This commit is contained in:
Charlie Marsh 2023-07-03 12:21:26 -04:00 • committed by GitHub
parent d2450c25ab
commit dadad0e9ed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 97 additions and 97 deletions
Download patch file Download diff file Expand all files Collapse all files

33
crates/ruff_python_ast/src/helpers.rs
View file

@ -4,7 +4,7 @@ use std::path::Path;
use num_traits::Zero;
use ruff_text_size::{TextRange, TextSize};
use rustc_hash::{FxHashMap, FxHashSet};
use rustc_hash::FxHashMap;
use rustpython_ast::CmpOp;
use rustpython_parser::ast::{
self, Arguments, Constant, ExceptHandler, Expr, Keyword, MatchCase, Pattern, Ranged, Stmt,
@ -669,25 +669,28 @@ pub fn extract_handled_exceptions(handlers: &[ExceptHandler]) -> Vec<&Expr> {
handled_exceptions
}
/// Return the set of all bound argument names.
pub fn collect_arg_names<'a>(arguments: &'a Arguments) -> FxHashSet<&'a str> {
let mut arg_names: FxHashSet<&'a str> = FxHashSet::default();
for arg_with_default in &arguments.posonlyargs {
arg_names.insert(arg_with_default.def.arg.as_str());
}
for arg_with_default in &arguments.args {
arg_names.insert(arg_with_default.def.arg.as_str());
/// Returns `true` if the given name is included in the given [`Arguments`].
pub fn includes_arg_name(name: &str, arguments: &Arguments) -> bool {
if arguments
.posonlyargs
.iter()
.chain(&arguments.args)
.chain(&arguments.kwonlyargs)
.any(|arg| arg.def.arg.as_str() == name)
{
return true;
}
if let Some(arg) = &arguments.vararg {
arg_names.insert(arg.arg.as_str());
}
for arg_with_default in &arguments.kwonlyargs {
arg_names.insert(arg_with_default.def.arg.as_str());
if arg.arg.as_str() == name {
return true;
}
}
if let Some(arg) = &arguments.kwarg {
arg_names.insert(arg.arg.as_str());
if arg.arg.as_str() == name {
return true;
}
}
arg_names
false
}
/// Given an [`Expr`] that can be callable or not (like a decorator, which could